Prevent tags for showing in sidebar for edited messages #5042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewGable
approved these changes
Sep 7, 2021
NikkiWines
changed the title
|
Corresponding Web-E PR is live, so this is now off hold. @AndrewGable do you know if I should hold off on merging this because of the |
|
Good question - My gut says yes, let's hold, but we could discuss further in Slack if you disagree. |
NikkiWines
changed the title
NikkiWines
changed the title
|
Re-tested and confirmed that this still fixes the original issue. Should be ready for review @AndrewGable! |
AndrewGable
approved these changes
Oct 18, 2021
|
Excited for this one! Feel free to merge once E2E is done if I don't get to it first. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by @NikkiWines in version: 1.1.8-10 🚀
|
|
🚀 Deployed to production by @roryabraham in version: 1.1.10-2 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Follow up to https://github.com/Expensify/Web-Expensify/pull/31834. Uses
message.textinstead ofmessage.htmlso that we don't show tags in the sidebar when you edit a messageHELD until https://github.com/Expensify/Web-Expensify/pull/31834 is live.
Fixed Issues
$ #4702
Tests / QA Steps
Tested On
Screenshots
Web
web.mov
Mobile Web
mweb.mov
Desktop
desktop.mov
iOS
ios.mov
Android