Refactor: reuse ValidateCodeActionModal

[getusha]

@hungvu193

Details

Fixed Issues

$
PROPOSAL:

Tests

New contact method

1. Open profile page
2. Navigate to Contact method > New Contact Method
3. Enter a new account
4. Add
5. Verify you’re navigated to magic code verification page
6. Enter the magic code received
7. Verify that the contact method Is added and you’re navigated to contact method list page

Verify contact method

1. Open profile page
2. Navigate to Contact method > New Contact Method
3. Press on unvalidated contact method
4. Verify you’re navigated to a magic code verification page
5. Enter the magic code sent to the new contact method
6. Verify the new contact method Is validated and you’re navigated to contact method list page

Copilot: Delegated access

1. Enable NewDotCopilot beta
2. Add copilot > Select an account
3. Press Limited > Add copilot
4. Verify you’re navigated to magic code verification page
5. Enter the magic code that was sent to your primary account
6. Verify that the copilot account is added

• Verify that no errors appear in the JS console

Offline tests

QA Steps

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

[hungvu193]

Note:
We should also need to make sure our temporary contact method has the same format with the contact method that will be sent from our BE

#48628 (comment)

[hungvu193]

@getusha mind looking at this convo and let me know your thoughts? 😄

[getusha]

@hungvu193 are you able to create account using a phone number?

Screen.Recording.2024-09-24.at.11.19.22.in.the.morning.mov

[hungvu193]

@hungvu193 are you able to create account using a phone number?

Screen.Recording.2024-09-24.at.11.19.22.in.the.morning.mov

I'm not, Unfortunately :/

[hungvu193]

Testing now 👀

[hungvu193]

I think we might need to delete this page right?

[hungvu193]

Let's remove this screen and add ValidateCodeActionModal to ConfirmDelegatePage and SecuritySettingsPage instead 😄

[getusha]

Yes, i was thinking that too that makes the most sense. i'll update it :)

[getusha]

@hungvu193 I realized this a little bit late but, seems like we may need to keep the page to avoid duplicate code

App/src/pages/settings/Security/SecuritySettingsPage.tsx

Line 88 in 05ca35c

Navigation.navigate(ROUTES.SETTINGS_DELEGATE_MAGIC_CODE.getRoute(email, role));

This page is accessed directly from SecuritySettingsPage as well. wdyt?

You mentioned this earlier, i didn't catch it :')

[hungvu193]

I think it's a little weird when a screen only contains a modal as a single view, I'm not sure if it's OK. So let's use ValidateCodeActionModal as a replacement 😄

[getusha]

I think it's a little weird when a screen only contains a modal as a single view, I'm not sure if it's OK. So let's use ValidateCodeActionModal as a replacement 😄

@hungvu193 what i am saying is, we'll just be duplicating the code in two pages while we can have it in a single page and re-use it.

[hungvu193]

@hungvu193 what i am saying is, we'll just be duplicating the code in two pages while we can have it in a single page and re-use it.

What's your plan? We still keep this screen or create a reusable component based on ValidateCodeModal?
My concern here is that a screen that return modal can lead to weird bugs with gestures. I used to face it before.

[getusha]

What's your plan? We still keep this screen or create a reusable component based on ValidateCodeModal?
My concern here is that a screen that return modal can lead to weird bugs with gestures. I used to face it before.

Yeah, you're right. creating a reusable component that'll include all the logic based on ValidateCodeModal sounds ideal. Keeping the screen doesn't seem that bad as well if we test it thoroughly.

[hungvu193]

Cool. Let's do it 🚀

[getusha]

@hungvu193 what do you think about this? 92a43b5

[hungvu193]

@hungvu193 what do you think about this? 92a43b5

Looks pretty good to me. Can you address the issue that we found during our last preview so I can start testing review again?

[getusha]

Looks pretty good to me. Can you address the issue that we found during our last preview so I can start testing review again?

@hungvu193 sorry, which one? 😄

[hungvu193]

Looks pretty good to me. Can you address the issue that we found during our last preview so I can start testing review again?

@hungvu193 sorry, which one? 😄

https://expensify.slack.com/archives/D07N0F7RE6Q/p1727171810042779
This one, I don't think there's a commit to fix it since our last convo?

[getusha]

@hungvu193 that's fixed https://github.com/Expensify/App/pull/49445/files#diff-83480a4b6a9a39b384509ec17b9f35136ce1a49805f968fd60cc1e8c5460a170R217-R232

[hungvu193]

@hungvu193 that's fixed https://github.com/Expensify/App/pull/49445/files#diff-83480a4b6a9a39b384509ec17b9f35136ce1a49805f968fd60cc1e8c5460a170R217-R232

Let me test it. Please address the lining 😄

[getusha]

On it! even though i have no idea what Changed files ESLint check is asking me to do :)

[hungvu193]

@hungvu193 that's fixed https://github.com/Expensify/App/pull/49445/files#diff-83480a4b6a9a39b384509ec17b9f35136ce1a49805f968fd60cc1e8c5460a170R217-R232

I think I still can reproduce this issue. Here's the reproduce steps:

1. Add new contact methods.
2. Enter correct magic code.
3. Click on that contact method that you've just added.
4. Click back, and click on that contact method again.

[getusha]

I think I still can reproduce this issue. Here's the reproduce steps:

Not the same issue but, it navigates back right?

[hungvu193]

I think I still can reproduce this issue. Here's the reproduce steps:

Not the same issue but, it navigates back right?

Yes and with a glitch animation

[mountiny]

@getusha @hungvu193 how is this looking?

[hungvu193]

I think I still can reproduce this issue. Here's the reproduce steps:

Not the same issue but, it navigates back right?

Yes and with a glitch animation

Pending on this one right here

[getusha]

finally the lint issue is gone 😄

[getusha]

Pending on this one right here

@hungvu193 please test this again 🙏
Let's test it thoroughly & just list the issues you discover i'll address them one by one