-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gets correct uri for file type #48755
gets correct uri for file type #48755
Conversation
…-pdf-trans-list-item
…-pdf-trans-list-item
…-pdf-trans-list-item
Reviewer Checklist
Screenshots/VideosAndroid: Nativeb1.webmAndroid: mWeb ChromeiOS: NativeSimulator.Screen.Recording.-.iPhone.15.Pro.-.2024-09-09.at.19.19.28.mp4iOS: mWeb SafariMacOS: Chrome / SafariScreen.Recording.2024-09-09.at.19.10.14.movMacOS: Desktop |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Details
Handles get the correct URI for pdf files.
Fixed Issues
$ #47387
PROPOSAL: #47387 (comment)
Tests
Offline tests
N/A
QA Steps
Same as Tests
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Test.thumbnail.-.android.mp4
Android: mWeb Chrome
Test.thumbnail.-.web.android.mp4
iOS: Native
Test.thumbnail.-.iOS.mov
iOS: mWeb Safari
Test.thumbnail.-.web.iOS.mov
MacOS: Chrome / Safari
Test.thumbnail.-.Web.mov
MacOS: Desktop
Test.thumbnail.-.Desktop.mov