Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the getPolicyName function for when the report or policies are not ready #48621

Merged
merged 7 commits into from
Sep 11, 2024
Merged

Fix the getPolicyName function for when the report or policies are not ready #48621

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
db25e26
Fix getPolicyName when report / policies not ready
wildan-m Sep 5, 2024
3134d83
lint
wildan-m Sep 5, 2024
93dbf1a
Add dummy reportID instead of empty
wildan-m Sep 5, 2024
d0a5e8b
Revert unnecessary changes
wildan-m Sep 5, 2024
73c2b03
Merge branch 'main' of https://github.com/wildan-m/App into wildan/fi…
wildan-m Sep 9, 2024
d49601a
Change solution that pass all test cases
wildan-m Sep 9, 2024
06ebc3c
Merge branch 'main' of https://github.com/wildan-m/App into wildan/fi…
wildan-m Sep 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions src/libs/ReportUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -735,13 +735,10 @@ const unavailableTranslation = Localize.translateLocal('workspace.common.unavail
*/
function getPolicyName(report: OnyxInputOrEntry<Report>, returnEmptyIfNotFound = false, policy?: OnyxInputOrEntry<Policy>): string {
const noPolicyFound = returnEmptyIfNotFound ? '' : unavailableTranslation;
if (isEmptyObject(report)) {
if (isEmptyObject(report) || (isEmptyObject(allPolicies) && !report?.policyName)) {
return noPolicyFound;
}

if ((!allPolicies || Object.keys(allPolicies).length === 0) && !report?.policyName) {
return unavailableTranslation;
}
const finalPolicy = policy ?? allPolicies?.[`${ONYXKEYS.COLLECTION.POLICY}${report?.policyID}`];

const parentReport = getRootParentReport(report);
Expand Down
Loading