[Xero] Update UpdatePolicyConnectionConfiguration to 1:1:1 - Part 1 #48492

mananjadhav · 2024-09-03T16:30:02Z

Details

Fixed Issues

$ #47443
PROPOSAL:

Tests

Prerequisite:
Your workspace need to connect with Xero.

Go to the selected workspace
Click on Accounting
Go to Import -> Chart of Accounts -> toggle the Enabled switch for categories. Ensure it works as before.
Go to Import -> Re-bill customers -> toggle the Import switch for customers. Ensure it works as before.
Go to Export -> Preferred Exporter -> from the list change the exporter -> Ensure it is reflected back in the preferred exporter list.
Go to Export -> Purchase bill date -> choose the options from the list. Ensure that the selected values are reflected in the list.
Go to Export -> Purchase status -> choose the options from the list. Ensure that the selected values are reflected in the. list.
Go to Export -> Xero bank account -> choose one of the bank accounts from the list. Ensure that the selected values are reflected in the list.
Go to Advanced -> Auto sync -> toggle the Auto-sync switch. Ensure it works as before.
Go to Advanced -> Sync reimbursed reports -> toggle the Sync reimbursed reports switch. Ensure it works as before.
Go to Advanced -> Xero bill payment account -> choose one of the bank accounts from the list. Ensure that the selected values are reflected in the list.
Go to Advanced -> Xero invoice collections account -> choose one of the bank accounts from the list. Ensure that the selected values are reflected in the list.

Verify that no errors appear in the JS console

Offline tests

Verify for all the steps the offline behavior works as before.

QA Steps

Same as Test steps.
Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android-xero-update-apis.mov

Android: mWeb Chrome

mweb-chrome-xero-update-apis.mov

iOS: Native

ios-xero-update-apis.mov

iOS: mWeb Safari

mweb-safari-xero-update-apis.mov

MacOS: Chrome / Safari

web-xero-export-import-options.mp4

web-xero-advanced-options.mov

MacOS: Desktop

desktop-xero-export-import-options.mov

…cy-config-xero

mananjadhav · 2024-09-04T03:16:39Z

@ishpaul777 You can start with the review if you want. I'll finish this checklist today.

ishpaul777 · 2024-09-06T12:54:35Z

sorry missed the ping, i'll put this on my list, expect to review this end of today/over the weekend

ishpaul777 · 2024-09-06T12:55:05Z

@mananjadhav please resolve conflict when you get chance

…cy-config-xero

melvin-bot · 2024-09-08T23:02:44Z

@ishpaul777 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mananjadhav · 2024-09-08T23:03:21Z

@ishpaul777 I am facing an issue with UpdateXeroSyncSyncReimbursedReports which I've raised here. The rest of it you can review.

ishpaul777 · 2024-09-10T11:01:23Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-09-13.at.10.48.49.PM.mov

Android: mWeb Chrome

Screen.Recording.2024-09-13.at.10.09.32.PM.mov

iOS: Native

Screen.Recording.2024-09-13.at.10.34.20.PM.mov

iOS: mWeb Safari

Screen.Recording.2024-09-11.at.2.03.05.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-09-11.at.1.42.19.AM-1.mov

MacOS: Desktop

Screen.Recording.2024-09-13.at.11.00.18.PM-1.mov

ishpaul777 · 2024-09-10T19:29:24Z

bug: Pending update grayed out pattern is not working on Export -> Purchase status, ig exist on main also possibly a easy fix

Screen.Recording.2024-09-11.at.12.52.36.AM.mov

ishpaul777 · 2024-09-10T19:51:08Z

src/libs/actions/connections/Xero.ts

NAB, I suggest we seperate actions in different files advanced/import/export for easy navigation and readability

I did think about it but didn't see a huge upside, considering we won't have too many other commands that'll be added. Let me know if you feel strongly about it.

I don't feel too strongly about it either, but it could be a nice-to-have improvement for readability. I'm okay with leaving it as is, thoughts @dangrous ?

Yeah that's interesting - I don't think there will be any new settings/commands we'll need to add... but it would definitely make it a lot more reader-friendly. Maybe if it's quick to do so, @mananjadhav, we add it in? But if it'll take a while I don't think it's necessary.

dangrous · 2024-09-11T23:20:56Z

@ishpaul777 I am facing an issue with UpdateXeroSyncSyncReimbursedReports which I've raised here. The rest of it you can review.

Posted on the issue too but this should be fixed on staging!

mananjadhav · 2024-09-12T01:37:51Z

Yes I'll test it now.

mananjadhav · 2024-09-12T01:38:53Z

bug: Pending update grayed out pattern is not working on Export -> Purchase status, ig exist on main also possibly a easy fix

I'll take a look today

ishpaul777 · 2024-09-12T14:58:53Z

finishing this today, only left with videos for all platforms

dangrous · 2024-09-13T17:01:04Z

how are we looking here? do you think we can get this merged today?

ishpaul777 · 2024-09-13T17:03:48Z

yes i am on it, was struggling with the android build, but now its sorted. Sorry for delay 🙇

ishpaul777

LGTM

dangrous

Great!

ishpaul777 · 2024-09-13T19:00:33Z

@dangrous can you also create a issue for #48492 (comment) since its still reproducable, i can raise a quick fix for it

OSBotify · 2024-09-13T19:10:20Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-09-13T23:05:39Z

🚀 Deployed to staging by https://github.com/dangrous in version: 9.0.35-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-09-16T18:21:36Z

🚀 Deployed to production by https://github.com/grgia in version: 9.0.35-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

mananjadhav added 7 commits August 26, 2024 23:18

feat: add new apis

0f1ad0c

Merge branch 'main' of github.com:mananjadhav/App into mj-update-poli…

795996a

…cy-config-xero

feat: added api types

d24e628

feat: added api calls for xero export

66ad3f4

Merge branch 'main' of github.com:mananjadhav/App into mj-update-poli…

a655a1b

…cy-config-xero

feat: added sync commands

d00e848

refactor: replace the commands

99deae8

Merge branch 'main' of github.com:mananjadhav/App into mj-update-poli…

d1b7e66

…cy-config-xero

mananjadhav marked this pull request as ready for review September 8, 2024 23:02

mananjadhav requested a review from a team as a code owner September 8, 2024 23:02

melvin-bot bot requested review from ishpaul777 and removed request for a team September 8, 2024 23:02

fix: update string values

6afdbba

ishpaul777 reviewed Sep 10, 2024

View reviewed changes

ishpaul777 approved these changes Sep 13, 2024

View reviewed changes

melvin-bot bot requested a review from dangrous September 13, 2024 17:34

dangrous approved these changes Sep 13, 2024

View reviewed changes

dangrous merged commit 4039a12 into Expensify:main Sep 13, 2024
19 of 20 checks passed

github-actions bot mentioned this pull request Sep 13, 2024

Deploy Checklist: New Expensify 2024-09-13 #49195

Closed

55 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Xero] Update UpdatePolicyConnectionConfiguration to 1:1:1 - Part 1 #48492

[Xero] Update UpdatePolicyConnectionConfiguration to 1:1:1 - Part 1 #48492

mananjadhav commented Sep 3, 2024 •

edited

Loading

mananjadhav commented Sep 4, 2024

ishpaul777 commented Sep 6, 2024

ishpaul777 commented Sep 6, 2024

melvin-bot bot commented Sep 8, 2024

mananjadhav commented Sep 8, 2024

ishpaul777 commented Sep 10, 2024 •

edited

Loading

ishpaul777 commented Sep 10, 2024 •

edited

Loading

ishpaul777 Sep 10, 2024

mananjadhav Sep 12, 2024

ishpaul777 Sep 12, 2024

dangrous Sep 12, 2024

dangrous commented Sep 11, 2024

mananjadhav commented Sep 12, 2024

mananjadhav commented Sep 12, 2024

ishpaul777 commented Sep 12, 2024

dangrous commented Sep 13, 2024

ishpaul777 commented Sep 13, 2024 •

edited

Loading

ishpaul777 left a comment

dangrous left a comment

ishpaul777 commented Sep 13, 2024 •

edited

Loading

OSBotify commented Sep 13, 2024

OSBotify commented Sep 13, 2024

OSBotify commented Sep 16, 2024

[Xero] Update UpdatePolicyConnectionConfiguration to 1:1:1 - Part 1 #48492

[Xero] Update UpdatePolicyConnectionConfiguration to 1:1:1 - Part 1 #48492

Conversation

mananjadhav commented Sep 3, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

mananjadhav commented Sep 4, 2024

ishpaul777 commented Sep 6, 2024

ishpaul777 commented Sep 6, 2024

melvin-bot bot commented Sep 8, 2024

mananjadhav commented Sep 8, 2024

ishpaul777 commented Sep 10, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

ishpaul777 commented Sep 10, 2024 • edited Loading

ishpaul777 Sep 10, 2024

Choose a reason for hiding this comment

mananjadhav Sep 12, 2024

Choose a reason for hiding this comment

ishpaul777 Sep 12, 2024

Choose a reason for hiding this comment

dangrous Sep 12, 2024

Choose a reason for hiding this comment

dangrous commented Sep 11, 2024

mananjadhav commented Sep 12, 2024

mananjadhav commented Sep 12, 2024

ishpaul777 commented Sep 12, 2024

dangrous commented Sep 13, 2024

ishpaul777 commented Sep 13, 2024 • edited Loading

ishpaul777 left a comment

Choose a reason for hiding this comment

dangrous left a comment

Choose a reason for hiding this comment

ishpaul777 commented Sep 13, 2024 • edited Loading

OSBotify commented Sep 13, 2024

OSBotify commented Sep 13, 2024

OSBotify commented Sep 16, 2024

mananjadhav commented Sep 3, 2024 •

edited

Loading

ishpaul777 commented Sep 10, 2024 •

edited

Loading

ishpaul777 commented Sep 10, 2024 •

edited

Loading

ishpaul777 commented Sep 13, 2024 •

edited

Loading

ishpaul777 commented Sep 13, 2024 •

edited

Loading