Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Role changed to admin member can't access compose box in workspace chat #48430

Merged
merged 6 commits into from
Sep 11, 2024
Merged

fix: Role changed to admin member can't access compose box in workspace chat #48430

Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
717e807
fix: Role changed to admin member can't access compose box in workspa…
daledah Sep 2, 2024
ddc2210
fix lint
daledah Sep 2, 2024
789c5ef
Merge branch 'main' into fix/47919
daledah Sep 5, 2024
30d39cb
Merge branch 'main' into fix/47919
daledah Sep 10, 2024
63b51d6
rename variable
daledah Sep 10, 2024
a838b60
Merge branch 'main' into fix/47919
daledah Sep 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/pages/home/report/ReportFooter.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,9 @@ function ReportFooter({

// If a user just signed in and is viewing a public report, optimistically show the composer while loading the report, since they will have write access when the response comes back.
const shouldShowComposerOptimistically = !isAnonymousUser && ReportUtils.isPublicRoom(report) && !!reportMetadata?.isLoadingInitialReportActions;
const shouldHideComposer = (!ReportUtils.canUserPerformWriteAction(report) && !shouldShowComposerOptimistically) || isBlockedFromChat;
// eslint-disable-next-line rulesdir/no-negated-variables
const cannotPerformWriteAction = !ReportUtils.canUserPerformWriteAction(report) && !shouldShowComposerOptimistically;
daledah marked this conversation as resolved.
Show resolved Hide resolved
const shouldHideComposer = cannotPerformWriteAction || isBlockedFromChat;
const canWriteInReport = ReportUtils.canWriteInReport(report);
const isSystemChat = ReportUtils.isSystemChat(report);
const isAdminsOnlyPostingRoom = ReportUtils.isAdminsOnlyPostingRoom(report);
Expand Down Expand Up @@ -238,5 +240,7 @@ export default memo(
prevProps.lastReportAction === nextProps.lastReportAction &&
prevProps.isReportReadyForDisplay === nextProps.isReportReadyForDisplay &&
prevProps.workspaceTooltip?.shouldShow === nextProps.workspaceTooltip?.shouldShow &&
lodashIsEqual(prevProps.reportMetadata, nextProps.reportMetadata),
lodashIsEqual(prevProps.reportMetadata, nextProps.reportMetadata) &&
lodashIsEqual(prevProps.policy?.employeeList, nextProps.policy?.employeeList) &&
lodashIsEqual(prevProps.policy?.role, nextProps.policy?.role),
);
Loading