-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide crossSubsidiaryCustomers selector when both customers and projects are not imported #47635
Conversation
…ts are not imported
@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@yuwenmemon Do we need my review here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks good to me. I'll work on the checklist in a while.
@DylanDylann @mananjadhav either/or! |
yeah I started on the checklist. |
I am a little blocked on the iOS testing due to some Xcode issues. I tried hard but can't get to working. I am going to post the checklist without iOS screenshots as the changes are not platform dependent. |
Reviewer Checklist
Screenshots/VideosAndroid: Nativeandroid-cross-subsidiary-hide.movAndroid: mWeb Chromemweb-chrome-cross-subsidiary-hide.moviOS: NativeiOS: mWeb Safarimweb-safari-cross-subsidiary-hide.movMacOS: Chrome / Safariweb-cross-subsidiary-hide.movMacOS: Desktopdesktop-cross-subsidiary-hide.mov |
@youssef-lr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.0.23-0 🚀
|
🚀 Deployed to production by https://github.com/chiragsalian in version: 9.0.23-0 🚀
|
cc @mananjadhav / @shubham1206agra
Details
We can hide the
crossSubsidiaryCustomers
selector when both Customers and Projects are turned off since the setting would not be applicable in that case and would otherwise cause confusion. To fix, hide it just like we do the "Displayed as" selector.Fixed Issues
$ #46288
Tests/QA
(Can skip 1-6 if you already have a NetSuite connection)
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop