[No QA] Implement OpenCardDetailsPage api call #47333

VickyStash · 2024-08-13T14:38:10Z

Details

Implement OpenCardDetailsPage api call

Fixed Issues

$ #47231
PROPOSAL: N/A

Tests

Verify that no errors appear in the JS console

Pre-steps: Have all betas/workspaceFeed beta enabled

Go to the workspace where Expensify Card feature is enabled and several cards are added.
Open Expensify Card screen from the workspace navigation menu -> tap on one of the cards.
Make sure the data in fields on the Card details screen is correct. Make sure the Remaining limit is displayed.
Go to Edit Card Limit screen and update the limit. Make sure the Remaining limit is optimistically updated.

Offline tests

Same as in the Tests section.

QA Steps

Verify that no errors appear in the JS console

Same as in the Tests section.

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

MacOS: Chrome / Safari

Offline:

…imit and earnedCashback fields into optional.

…-api-call # Conflicts: # src/libs/API/parameters/index.ts

melvin-bot · 2024-08-14T13:17:26Z

@Pujan92 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

VickyStash · 2024-08-14T13:19:40Z

@allgandalf or @DylanDylann should be a C+ reviewer here

DylanDylann · 2024-08-14T14:11:12Z

src/libs/API/parameters/OpenCardDetailsPageParams.ts

@@ -0,0 +1,6 @@
+type OpenCardDetailsPageParams = {


Add my reviewing

mountiny

Looking good!

mountiny · 2024-08-15T06:41:56Z

@DylanDylann lets try to get this one reviewed and merged today if everything will work well

DylanDylann · 2024-08-15T09:03:02Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

MacOS: Chrome / Safari

DylanDylann · 2024-08-15T09:17:45Z

src/pages/workspace/expensifyCard/WorkspaceExpensifyCardDetailsPage.tsx

@@ -111,6 +120,7 @@ function WorkspaceExpensifyCardDetailsPage({route}: WorkspaceExpensifyCardDetail
                                title={formattedAvailableSpendAmount}
                                interactive={false}
                                titleStyle={styles.newKansasLarge}
+                                containerStyle={isOffline ? styles.buttonOpacityDisabled : null}


@mountiny @VickyStash We always greyed out the remaining limit field when offline (even though there are no pending action), right?

@DylanDylann Correct because we cant know if the data is correct / up to date

DylanDylann

@mountiny Everything else looks good

Not related to this PR, I see that the offline pattern hasn't applied to this feature yet, the updated field should be greyed out if It is updated offline

mountiny · 2024-08-15T10:12:16Z

Not related to this PR, I see that the offline pattern hasn't applied to this feature yet, the updated field should be greyed out if It is updated offline

Can you explain this with numbered steps?

mountiny

Changes look good to me, thank you!

mountiny · 2024-08-15T10:14:39Z

@DylanDylann comment is NAB and can be handled later

OSBotify · 2024-08-15T10:32:28Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-08-15T18:20:06Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.21-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-08-19T16:01:10Z

🚀 Deployed to production by https://github.com/Beamanator in version: 9.0.21-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	failure ❌

OSBotify · 2024-08-19T16:25:34Z

🚀 Deployed to production by https://github.com/Beamanator in version: 9.0.21-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

VickyStash added 2 commits August 13, 2024 16:32

Implement OpenCardDetailsPage api call

e4194a1

Add sortCardsByCardholderName method. Turn currentBalance, remainingL…

f79957c

…imit and earnedCashback fields into optional.

VickyStash mentioned this pull request Aug 13, 2024

[Workspace Feeds] Create OpenCardDetailsPage api command #47231

Closed

VickyStash added 2 commits August 14, 2024 12:37

Merge branch 'refs/heads/main' into feature/47231-OpenCardDetailsPage…

cf90991

…-api-call # Conflicts: # src/libs/API/parameters/index.ts

Lint fixes

684cfeb

mountiny assigned VickyStash Aug 14, 2024

mountiny self-requested a review August 14, 2024 11:49

Update availableSpend value optimistically

d692b67

VickyStash changed the title ~~[WIP] Implement OpenCardDetailsPage api call~~ [No QA] Implement OpenCardDetailsPage api call Aug 14, 2024

VickyStash marked this pull request as ready for review August 14, 2024 13:17

VickyStash requested a review from a team as a code owner August 14, 2024 13:17

melvin-bot bot requested a review from Pujan92 August 14, 2024 13:17

melvin-bot bot removed the request for review from a team August 14, 2024 13:17

DylanDylann reviewed Aug 14, 2024

View reviewed changes

src/libs/API/parameters/OpenCardDetailsPageParams.ts

@@ -0,0 +1,6 @@

type OpenCardDetailsPageParams = {

Copy link

Contributor

DylanDylann Aug 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add my reviewing

mountiny removed the request for review from Pujan92 August 14, 2024 14:34

mountiny approved these changes Aug 14, 2024

View reviewed changes

DylanDylann reviewed Aug 15, 2024

View reviewed changes

DylanDylann approved these changes Aug 15, 2024

View reviewed changes

melvin-bot bot requested a review from mountiny August 15, 2024 09:23

mountiny approved these changes Aug 15, 2024

View reviewed changes

mountiny merged commit c880993 into Expensify:main Aug 15, 2024
18 of 23 checks passed

github-actions bot mentioned this pull request Aug 15, 2024

Deploy Checklist: New Expensify 2024-08-15 #47512

Closed

74 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[No QA] Implement OpenCardDetailsPage api call #47333

[No QA] Implement OpenCardDetailsPage api call #47333

VickyStash commented Aug 13, 2024 •

edited

Loading

melvin-bot bot commented Aug 14, 2024

VickyStash commented Aug 14, 2024

DylanDylann Aug 14, 2024

mountiny left a comment

mountiny commented Aug 15, 2024

DylanDylann commented Aug 15, 2024 •

edited

Loading

DylanDylann Aug 15, 2024

mountiny Aug 15, 2024

DylanDylann left a comment

mountiny commented Aug 15, 2024

mountiny left a comment

mountiny commented Aug 15, 2024

OSBotify commented Aug 15, 2024

OSBotify commented Aug 15, 2024

OSBotify commented Aug 19, 2024

OSBotify commented Aug 19, 2024

[No QA] Implement OpenCardDetailsPage api call #47333

[No QA] Implement OpenCardDetailsPage api call #47333

Conversation

VickyStash commented Aug 13, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Aug 14, 2024

VickyStash commented Aug 14, 2024

DylanDylann Aug 14, 2024

Choose a reason for hiding this comment

mountiny left a comment

Choose a reason for hiding this comment

mountiny commented Aug 15, 2024

DylanDylann commented Aug 15, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

DylanDylann Aug 15, 2024

Choose a reason for hiding this comment

mountiny Aug 15, 2024

Choose a reason for hiding this comment

DylanDylann left a comment

Choose a reason for hiding this comment

mountiny commented Aug 15, 2024

mountiny left a comment

Choose a reason for hiding this comment

mountiny commented Aug 15, 2024

OSBotify commented Aug 15, 2024

OSBotify commented Aug 15, 2024

OSBotify commented Aug 19, 2024

OSBotify commented Aug 19, 2024

VickyStash commented Aug 13, 2024 •

edited

Loading

DylanDylann commented Aug 15, 2024 •

edited

Loading