fix: remove Expensify employee from list participants #47214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melvin-bot
bot
requested review from
ahmedGaber93
and removed request for
a team
|
@ahmedGaber93 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Closed
6 tasks
|
@daledah I am still able to reproduce the issue on desktop 20240814131310473.mp4I think we can add |
|
@daledah Please add test step to clear cache to confirm admins room is using server data not optimistic |
|
@daledah bump ^ |
|
I'll update soon |
|
@ahmedGaber93 I tested again, and I can't reproduce the bug, in both cases of clearing cache and offline. Can you spot the step that I may have done wrong? Screen.Recording.2024-08-21.at.02.50.51.movScreen.Recording.2024-08-21.at.02.51.40.mov |
|
@daledah It reproduced with me on desktop only and clearing cache. Can you try it on desktop? |
|
@ahmedGaber93 Strange... I can't reproduce the bug on desktop either Screen.Recording.2024-08-21.at.20.53.43.mov |
|
This seems to be a race condition issue, try with slow network speed |
|
@ahmedGaber93 I think network speed is not the reason for the bug Screen.Recording.2024-08-22.at.00.21.56.mp4 |
|
For me, I am still able to reproduce 20240821113752708.mp4 |
|
@daledah I do some debugging and I found So I think we need to add I know you don't able to reproduce this, but it seems a race condition and not reproduced every time. Do you think the above investigation logically? |
|
@ahmedGaber93 I updated. Can you check if the bug still exists? |
It works fine now 👍 @daledah just small change on test steps - 2. Clear cache
- 3. Go to #admins room
+ 2. Go to "troubleshoot" and click "Clear cache and restart"
+ 3. Go to "Workspaces" and in the list use the 3 dots menu beside the workspace you create it and navigate to #admin room |
Reviewer Checklist
Screenshots/VideosAndroid: Nativea.mp4Android: mWeb Chromeaw.mp4iOS: Nativei.mp4iOS: mWeb Safariiw.mp4MacOS: Chrome / Safariw.mp4MacOS: Desktop20240822112632713.mp4 |
Gonals
approved these changes
Aug 26, 2024
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
github-actions
bot
added
the
DeployBlockerCash
Performance Comparison Report 📊Significant Changes To Duration
Show details
Meaningless Changes To DurationShow entries
Show details
|
|
@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker. |
|
🚀 Deployed to staging by https://github.com/Gonals in version: 9.0.25-0 🚀
|
1 similar comment
|
🚀 Deployed to staging by https://github.com/Gonals in version: 9.0.25-0 🚀
|
6 tasks
48 tasks
luacmartins
removed
the
DeployBlockerCash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Fixed Issues
$ #46739
PROPOSAL: #46739 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2024-08-13.at.10.02.51.mov
Android: mWeb Chrome
Screen.Recording.2024-08-13.at.09.53.13.mov
iOS: Native
Screen.Recording.2024-08-13.at.10.47.17.mov
iOS: mWeb Safari
Screen.Recording.2024-08-13.at.10.12.44.mov
MacOS: Chrome / Safari
Screen.Recording.2024-08-12.at.13.21.46.mov
MacOS: Desktop
Screen.Recording.2024-08-13.at.10.21.15.mov