-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle expense type #47098
Handle expense type #47098
Conversation
@rayane-djouah Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@@ -24,7 +24,8 @@ type SelectedTransactions = Record<string, SelectedTransactionInfo>; | |||
|
|||
type SortOrder = ValueOf<typeof CONST.SEARCH.SORT_ORDER>; | |||
type SearchColumnType = ValueOf<typeof CONST.SEARCH.TABLE_COLUMNS>; | |||
type SearchStatus = ValueOf<typeof CONST.SEARCH.STATUS>; | |||
type ExpenseSearchStatus = ValueOf<typeof CONST.SEARCH.STATUS.EXPENSE>; | |||
type SearchStatus = ExpenseSearchStatus; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll add more statuses to this type soon, so I'm creating this now
TRANSACTION: 'transaction', | ||
REPORT: 'report', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
transaction
and report
will be removed in a clean up PR, once the backend starts sending expense
type
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2024-08-09.at.7.12.22.PM.movAndroid: mWeb ChromeScreen.Recording.2024-08-09.at.7.08.50.PM.moviOS: NativeSimulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-08-09.at.19.07.47.mp4iOS: mWeb SafariSimulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-08-09.at.19.00.55.mp4MacOS: Chrome / SafariScreen.Recording.2024-08-09.at.6.35.25.PM.1.movMacOS: DesktopScreen.Recording.2024-08-09.at.6.56.18.PM.mov |
Noticed a console warning but I'm getting it also on main so not related to this PR I've fixed it here: #47185 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and tests well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/dangrous in version: 9.0.19-2 🚀
|
🚀 Deployed to staging by https://github.com/dangrous in version: 9.0.19-4 🚀
|
🚀 Deployed to staging by https://github.com/dangrous in version: 9.0.19-5 🚀
|
🚀 Deployed to staging by https://github.com/dangrous in version: 9.0.20-0 🚀
|
FYI I believe this was deployed to prod yesterday, from this checklist - #47356 |
Details
Refactors existing search data types to handle the new combined
expense
type. We'll remove the previoustransaction
andreport
types once both backend and App are updated to use justexpense
.Fixed Issues
$ #46580
Tests
Offline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop