Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CRITICAL] Implement <WorkspaceWorkflowsApprovalsCreatePage /> for Workflow Creation #46798

Merged
merged 50 commits into from
Aug 13, 2024
Merged

[CRITICAL] Implement <WorkspaceWorkflowsApprovalsCreatePage /> for Workflow Creation #46798

merged 50 commits into from
Aug 13, 2024

Commits on Aug 5, 2024

  1. Test navigation

    @blazejkustra
    blazejkustra committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    88e2519 View commit details
    Browse the repository at this point in the history

  2. Fix navigating between screens for create flow

    @blazejkustra
    blazejkustra committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    b0878c5 View commit details
    Browse the repository at this point in the history

  3. Attach API action

    @blazejkustra
    blazejkustra committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    66c99d3 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'Guccio163/45951_implementApprovalWorkflowSection' into … 

    …approval-workflows/create-edit-screen
    @blazejkustra
    blazejkustra committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    a0c289b View commit details
    Browse the repository at this point in the history

  5. Fix small mistakes and old comments

    @blazejkustra
    blazejkustra committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    11372db View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2024

  1. Add translations

    @blazejkustra
    blazejkustra committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    d243bd5 View commit details
    Browse the repository at this point in the history

  2. Add one more translation

    @blazejkustra
    blazejkustra committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    d1f0dce View commit details
    Browse the repository at this point in the history

  3. Add an option to parse text in formHelpMessage component

    @blazejkustra
    blazejkustra committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    5108e12 View commit details
    Browse the repository at this point in the history

  4. Adjust MenuItem component to allow parsing text in formHelpMessage co… 

    …mponent
    @blazejkustra
    blazejkustra committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    062e45a View commit details
    Browse the repository at this point in the history

  5. Fix minor errors

    @blazejkustra
    blazejkustra committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    c0734c8 View commit details
    Browse the repository at this point in the history

  6. Create a new type for ApprovalWorkflow that is kept in onyx

    @blazejkustra
    blazejkustra committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    89f6ee0 View commit details
    Browse the repository at this point in the history

  7. Take care of all edge cases and error handling

    @blazejkustra
    blazejkustra committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    8405648 View commit details
    Browse the repository at this point in the history

  8. Allow to deselect an approver

    @blazejkustra
    blazejkustra committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    3a39deb View commit details
    Browse the repository at this point in the history

  9. Clean the expenses from page logic

    @blazejkustra
    blazejkustra committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    c4da7e3 View commit details
    Browse the repository at this point in the history

  10. Create an ApprovalWorkflowEditor and adjust CreatePage logic

    @blazejkustra
    blazejkustra committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    dbb4311 View commit details
    Browse the repository at this point in the history

  11. Merge branch 'main' into approval-workflows/create-edit-screen

    @blazejkustra
    blazejkustra committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    e92b654 View commit details
    Browse the repository at this point in the history

  12. Bring back Permissions.ts

    @blazejkustra
    blazejkustra committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    d4ae460 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2024

  1. Remove backTo from WORKSPACE_WORKFLOWS_APPROVALS_NEW screen

    @blazejkustra
    blazejkustra committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    77555f3 View commit details
    Browse the repository at this point in the history

  2. Fix tests

    @blazejkustra
    blazejkustra committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    1c6ae4b View commit details
    Browse the repository at this point in the history

  3. Do final corrections

    @blazejkustra
    blazejkustra committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    31d8863 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into approval-workflows/create-edit-screen

    @blazejkustra
    blazejkustra committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    faee4e3 View commit details
    Browse the repository at this point in the history

  5. Fix displaying errors and sorting default workflow

    @blazejkustra
    blazejkustra committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    ebd1e05 View commit details
    Browse the repository at this point in the history

  6. Fix lint

    @blazejkustra
    blazejkustra committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    9fa7889 View commit details
    Browse the repository at this point in the history

  7. Change util name to calculateApprovers, fix that circular approver wa… 

    …snt marked as one
    @blazejkustra
    blazejkustra committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    69c31e2 View commit details
    Browse the repository at this point in the history

  8. Address comments after initial review

    @blazejkustra
    blazejkustra committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    b67e8b8 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'main' into approval-workflows/create-edit-screen

    @blazejkustra
    blazejkustra committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    ba8a3d3 View commit details
    Browse the repository at this point in the history

  10. Fix copilot mistake 🙄

    @blazejkustra
    blazejkustra committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    755954c View commit details
    Browse the repository at this point in the history

  11. Adjust a comment

    @blazejkustra
    blazejkustra committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    603b6ff View commit details
    Browse the repository at this point in the history

  12. Remove role from CreateWorkspaceApprovalParams

    @blazejkustra
    blazejkustra committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    230080e View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2024

  1. Filter out the default approver when selecting the first approver for… 

    … a workflow
    @blazejkustra
    blazejkustra committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    54453fb View commit details
    Browse the repository at this point in the history

  2. Fix how form errors are displayed

    @blazejkustra
    blazejkustra committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    b9b7937 View commit details
    Browse the repository at this point in the history

  3. Fix lint

    @blazejkustra
    blazejkustra committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    68d5caf View commit details
    Browse the repository at this point in the history

  4. Improve error handling

    @blazejkustra
    blazejkustra committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    64e7f0b View commit details
    Browse the repository at this point in the history

  5. Implement the logic similar to other function

    @blazejkustra
    blazejkustra committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    cd36817 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2024

  1. Merge branch 'main' into approval-workflows/create-edit-screen

    @blazejkustra
    blazejkustra committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    436457b View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2024

  1. Merge branch 'main' into approval-workflows/create-edit-screen

    @blazejkustra
    blazejkustra committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    4c0078a View commit details
    Browse the repository at this point in the history

  2. Use const for flow and mode options

    @blazejkustra
    blazejkustra committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    17cab91 View commit details
    Browse the repository at this point in the history

  3. Clean the logic for displaying hints

    @blazejkustra
    blazejkustra committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    f554da6 View commit details
    Browse the repository at this point in the history

  4. Fix that additionalApprover error is cleared

    @blazejkustra
    blazejkustra committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    6707500 View commit details
    Browse the repository at this point in the history

  5. Revert "Clean the logic for displaying hints" 

    This reverts commit f554da6.
    @blazejkustra
    blazejkustra committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    c38d5d7 View commit details
    Browse the repository at this point in the history

  6. Improve isInMultipleWorkflows logic

    @blazejkustra
    blazejkustra committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    d74ed36 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2024

  1. Rename consts

    @blazejkustra
    blazejkustra committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    f9ea365 View commit details
    Browse the repository at this point in the history

  2. Enable submit button when offline

    @blazejkustra
    blazejkustra committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    9bde486 View commit details
    Browse the repository at this point in the history

  3. Implement offline pattern B

    @blazejkustra
    blazejkustra committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    e732c6c View commit details
    Browse the repository at this point in the history

  4. Remove redundant code

    @blazejkustra
    blazejkustra committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    05c552f View commit details
    Browse the repository at this point in the history

  5. Fix code formatting

    @blazejkustra
    blazejkustra committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    914bb1f View commit details
    Browse the repository at this point in the history

  6. Remove unnecessary test case

    @blazejkustra
    blazejkustra committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    30d8a6a View commit details
    Browse the repository at this point in the history

  7. Move key further up

    @blazejkustra
    blazejkustra committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    14f6eb2 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'main' into approval-workflows/create-edit-screen

    @blazejkustra
    blazejkustra committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    69ab537 View commit details
    Browse the repository at this point in the history

  9. Rename variables

    @blazejkustra
    blazejkustra committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    5f3f64f View commit details
    Browse the repository at this point in the history