[No QA] Card reconciliation page #45606
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
As mentioned in this comment #44968 (comment) - another PR for Card Reconciliation page content
Fixed Issues
$ #44315
PROPOSAL:
Tests
PREREQUISITES: a workspace with accounting connections enabled
MOBILE: with app built and simulator open type in terminal either:
npx uri-scheme open new-expensify://settings/workspaces/<workspaceID>/accounting/<connection>/card-reconciliation --ios
or
npx uri-scheme open new-expensify://settings/workspaces/<workspaceID>/accounting/<connection>/card-reconciliation —android
WEB/mWEB: add
settings/workspaces/<workspaceID>/accounting/<connection>/card-reconciliation
to the root URLDESKTOP: with the app open type the address in the bar:
staging.new.expensify.com/settings/workspaces/<workspaceID>/accounting/<connection>/card-reconciliation
and open app from the prompt. (You must be logged to the same account on staging and in the desktop app)/settings/workspaces/<workspaceID>/accounting/<connection>/card-reconciliation/account
(for now this page is hidden, but you will see a change in the URL)Offline tests
QA Steps
n/a
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop