Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Split - App does not throw an error when saving the empty merchant field. #45371

Merged
merged 2 commits into from
Jul 15, 2024
Merged

fix: Split - App does not throw an error when saving the empty merchant field. #45371

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b9b1a1
fix: Split - App does not throw an error when saving the empty mercha…
Krishna2323 Jul 13, 2024
07def0a
add ReportUtils.isExpenseRequest(report) check back.
Krishna2323 Jul 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/pages/iou/request/step/IOURequestStepMerchant.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,8 @@ function IOURequestStepMerchant({
const merchant = ReportUtils.getTransactionDetails(isEditingSplitBill && !isEmptyObject(splitDraftTransaction) ? splitDraftTransaction : transaction)?.merchant;
const isEmptyMerchant = merchant === '' || merchant === CONST.TRANSACTION.PARTIAL_TRANSACTION_MERCHANT;

const isMerchantRequired = ReportUtils.isExpenseRequest(report) || transaction?.participants?.some((participant) => !!participant.isPolicyExpenseChat);
const isMerchantRequired =
ReportUtils.isPolicyExpenseChat(report) || ReportUtils.isExpenseRequest(report) || transaction?.participants?.some((participant) => !!participant.isPolicyExpenseChat);

const navigateBack = () => {
Navigation.goBack(backTo);
Expand Down
Loading