Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CP Staging] Revert "fix: No option to add receipt when submitting to someone" #45081

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

rlinoz
Copy link
Contributor

@rlinoz rlinoz commented Jul 9, 2024

Reverts #44670 to fix #45062

ConvertTrackedExpenseToRequest doesn't accept a receipt as parameter, so we can't show the Add Receipt button when converting to request yet.

@rlinoz rlinoz self-assigned this Jul 9, 2024
@rlinoz rlinoz marked this pull request as ready for review July 9, 2024 14:28
@rlinoz rlinoz requested a review from a team as a code owner July 9, 2024 14:28
@melvin-bot melvin-bot bot requested review from deetergp and removed request for a team July 9, 2024 14:28
Copy link

melvin-bot bot commented Jul 9, 2024

@deetergp Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@rlinoz rlinoz changed the title Revert "fix: No option to add receipt when submitting to someone" [CP Staging] Revert "fix: No option to add receipt when submitting to someone" Jul 9, 2024
@rlinoz rlinoz merged commit 89c9d2e into main Jul 9, 2024
12 of 16 checks passed
@rlinoz rlinoz deleted the revert-44670-fix/43942 branch July 9, 2024 14:36
@melvin-bot melvin-bot bot added the Emergency label Jul 9, 2024
Copy link

melvin-bot bot commented Jul 9, 2024

@rlinoz looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@rlinoz rlinoz removed the Emergency label Jul 9, 2024
@rlinoz
Copy link
Contributor Author

rlinoz commented Jul 9, 2024

Skipped the checklist because this is a straight revert to fix a blocker.

OSBotify pushed a commit that referenced this pull request Jul 9, 2024
[CP Staging] Revert "fix: No option to add receipt when submitting to someone"

(cherry picked from commit 89c9d2e)
@OSBotify
Copy link
Contributor

OSBotify commented Jul 9, 2024

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

OSBotify commented Jul 9, 2024

🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.0.5-9 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Contributor

OSBotify commented Jul 9, 2024

🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.0.5-10 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.5-13 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.6-8 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Track - App shows old receipt when submitting expense with receipt and changing receipt
3 participants