-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix keyboard overlap composer #44428
fix keyboard overlap composer #44428
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2024-06-29.at.00.26.50.movAndroid: mWeb ChromeScreen.Recording.2024-06-29.at.00.29.01.moviOS: NativeScreen.Recording.2024-06-29.at.00.32.57.moviOS: mWeb SafariScreen.Recording.2024-06-29.at.00.32.04.movMacOS: Chrome / SafariScreen.Recording.2024-06-29.at.00.35.30.movMacOS: DesktopScreen.Recording.2024-06-29.at.00.36.06.mov |
@@ -435,6 +436,7 @@ function ReportActionItemMessageEdit( | |||
} | |||
setShouldShowComposeInputKeyboardAware(true); | |||
}} | |||
onLayout={reportActionItemEventHandler.onLayout(reportScrollManager, index)} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The callback methods have to be named for what the method does so we have to update callback func ST like that
onLayout={reportActionItemEventHandler.onLayout(reportScrollManager, index)} | |
onLayout={reportActionItemEventHandler.handleComposerLayoutChange(reportScrollManager, index)} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@suneox I have updated this change as you suggested. Can you check it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -29,6 +29,7 @@ import focusEditAfterCancelDelete from '@libs/focusEditAfterCancelDelete'; | |||
import {parseHtmlToMarkdown} from '@libs/OnyxAwareParser'; | |||
import onyxSubscribe from '@libs/onyxSubscribe'; | |||
import ReportActionComposeFocusManager from '@libs/ReportActionComposeFocusManager'; | |||
import reportActionItemEventHandler from '@libs/ReportActionItemEventHandler/index.android'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For my understanding. Why do we only import the index.android part?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @puneetlath My mistake, auto-import in my IDE. I have updated it. Can you check it again?
@@ -29,6 +29,7 @@ import focusEditAfterCancelDelete from '@libs/focusEditAfterCancelDelete'; | |||
import {parseHtmlToMarkdown} from '@libs/OnyxAwareParser'; | |||
import onyxSubscribe from '@libs/onyxSubscribe'; | |||
import ReportActionComposeFocusManager from '@libs/ReportActionComposeFocusManager'; | |||
import reportActionItemEventHandler from '@libs/ReportActionItemEventHandler/index'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we typically just import like this?
import reportActionItemEventHandler from '@libs/ReportActionItemEventHandler/index'; | |
import reportActionItemEventHandler from '@libs/ReportActionItemEventHandler'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated it as you suggested. Do you have any more feedback?
@huult looks like you have some unsigned commits, so that check is failing. |
Hi @puneetlath , @suneox , I have fixed everything. Can you double-check? Thank you! |
Some commits are still un-signed. |
e57c19e
to
7e0c8a6
Compare
Hi @puneetlath , Sorry for that. My signing tool had an error, so the merges on my branch were not signed. I rebased the commits into one and resolved the signing issue. Could you please check it again? |
Ok cool thanks. @suneox mind giving it a quick re-review/test? And then I can final-review/merge. |
Sure, I'll test again on all platform in few hours |
@huult Could you please merge latest main to fix an issue patch-package when install package? |
7e0c8a6
to
50a4af1
Compare
@suneox it's done |
@puneetlath I have tested it, and it still works on the latest main branch. Screenshots/VideosAndroid: NativeScreen.Recording.2024-07-02.at.13.00.50.movAndroid: mWeb ChromeScreen.Recording.2024-07-02.at.13.07.31.moviOS: NativeScreen.Recording.2024-07-02.at.13.12.24.moviOS: mWeb SafariScreen.Recording.2024-07-02.at.13.15.23.movMacOS: Chrome / SafariScreen.Recording.2024-07-02.at.12.56.57.movMacOS: DesktopScreen.Recording.2024-07-02.at.12.58.47.mov |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/puneetlath in version: 9.0.4-0 🚀
|
🚀 Cherry-picked to staging by https://github.com/tgolen in version: 9.0.4-5 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.5-13 🚀
|
🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.6-8 🚀
|
Details
Fixed Issues
$ #43615
PROPOSAL: #43615 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Screen_Recording_20240627_200038_New.Expensify.Dev.mp4
Android: mWeb Chrome
Screen.Recording.2024-06-26.at.10.26.30.mov
iOS: Native
Screen.Recording.2024-06-26.at.00.15.59.mov
iOS: mWeb Safari
Screen.Recording.2024-06-26.at.09.44.06.mov
MacOS: Chrome / Safari
Screen.Recording.2024-06-26.at.13.20.52.mov
MacOS: Desktop
Screen.Recording.2024-06-26.at.00.23.38.mov