Don't show loading state in workspace setup button #4401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-mechler
reviewed
Aug 3, 2021
| @@ -179,7 +179,6 @@ const WorkspaceCardPage = ({ | |||
| success | |||
| large | |||
| text={buttonText} | |||
| isLoading={reimbursementAccount.loading} | |||
There was a problem hiding this comment.
Is there any case where this can be true, but the modal is not open?
There was a problem hiding this comment.
Nope, not that I know of / could figure out
alex-mechler
approved these changes
Aug 4, 2021
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
This was referenced Aug 5, 2021
|
🚀 Deployed to staging in version: 1.0.82-8🚀
|
|
@stitesExpensify Hello! Our testing domains already have a Expensify card set and we're not able to access this flow. Can you provide a testing account for this or test this internally? |
|
This is no QA and can be checked off. I mentioned it in the PR body but forgot to put it in the title, my bad |
|
🚀 Deployed to production by @francoisl in version: 1.0.83-1 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
We were getting double spinners when setting up workspaces. We only want the sidebar loading icon, not the button.
Fixed Issues
$ #4384
Tests
QA Steps
n/a
Tested On
Screenshots