Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes styling for hidden element again #4394

Merged
merged 1 commit into from
Aug 3, 2021
Merged

Fixes styling for hidden element again #4394

merged 1 commit into from
Aug 3, 2021

Conversation

rdjuric
Copy link
Contributor

@rdjuric rdjuric commented Aug 3, 2021

Details

The changes from the previous PR (#4158) were undone by mistake, so this PR only applies the fix again.

Fixed Issues

$ #3296

Tests

QA Steps

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

web.mov

Mobile Web

mWeb.mp4

Desktop

desktop.mov

iOS

iPhone.mp4
iPad.mov

Android

Android.mp4

@rdjuric rdjuric marked this pull request as ready for review August 3, 2021 20:43
@rdjuric rdjuric requested a review from a team as a code owner August 3, 2021 20:43
@MelvinBot MelvinBot requested review from ctkochan22 and removed request for a team August 3, 2021 20:44
@ctkochan22 ctkochan22 merged commit c24c83b into Expensify:main Aug 3, 2021
@OSBotify
Copy link
Contributor

OSBotify commented Aug 3, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

OSBotify commented Aug 6, 2021

🚀 Deployed to staging in version: 1.0.82-8🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@isagoico
Copy link

isagoico commented Aug 6, 2021

@rdjuric Hello! Any QA tests needed for this PR ?

@rdjuric
Copy link
Contributor Author

rdjuric commented Aug 6, 2021

Sorry, @isagoico! Should be the same steps as #4158

  1. Open the app on an iPad Pro in Landscape mode
  2. Start the IOU flow (request money or split bill)
  3. You should be able to type an amount

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @francoisl in version: 1.0.83-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants