Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat Default Chat Rooms like Multiple Participant Rooms when it comes to their OptionRow->login property #4393

Merged
merged 1 commit into from
Aug 3, 2021

Conversation

yuwenmemon
Copy link
Contributor

@TomatoToaster please review

Details

Weird edge case where we treated Default Chat Rooms like DMs for the login property in OptionsListUtils when there was only one other participant in it. I think essentially we should just treat Default Chat Rooms like Multiple Participant Rooms in this case.

Fixed Issues

$ #4376

Tests/QA

  1. Login with Account A (Be sure it's new with no Workspaces)
  2. Create a Workspace and invite user B
  3. Navigate to the conversation with user B and send some messages
  4. Navigate to #Announce room and send some messages
  5. Make sure both the #Announce room and the DM show up in the LHN
  6. Send messages in each, make sure neither ends up disappearing from the LHN and that they re-organize in order of most recent:
    Kapture 2021-08-03 at 13 12 01
  7. Search for each room, make sure the search functionality works as expected:
    Kapture 2021-08-03 at 13 17 49

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

@yuwenmemon yuwenmemon self-assigned this Aug 3, 2021
@yuwenmemon yuwenmemon requested a review from a team as a code owner August 3, 2021 17:20
@MelvinBot MelvinBot requested review from madmax330 and removed request for a team August 3, 2021 17:20
@madmax330 madmax330 merged commit 2d689a8 into main Aug 3, 2021
@madmax330 madmax330 deleted the yuwen-defaultRoomShow branch August 3, 2021 18:17
@OSBotify
Copy link
Contributor

OSBotify commented Aug 3, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

OSBotify commented Aug 6, 2021

🚀 Deployed to staging in version: 1.0.82-8🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @francoisl in version: 1.0.83-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants