Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta Tweaks for #4275 #4383

Merged
merged 2 commits into from
Aug 3, 2021
Merged

Meta Tweaks for #4275 #4383

merged 2 commits into from
Aug 3, 2021

Conversation

aman-atg
Copy link
Contributor

@aman-atg aman-atg commented Aug 2, 2021

cc: @tgolen

Details

( comment )
Patch for #4275

Fixed Issues

$ #4234

Tests || ### QA Steps

  1. Login to New Expensify
  2. Change language to Spanish
  3. Request money from someone or Go to a chat where money is requested from you
  4. Click on the amount or view details link
  5. button text will not look unusual (Cancel/Decline)

Tested On

  • Web
  • Mobile Web
  • Android
  • Desktop
  • iOS

Screenshots

Web

patch.mp4

Mobile Web

Web.mp4

Desktop

image

iOS

image

Android

android.mp4

@aman-atg aman-atg requested a review from a team as a code owner August 2, 2021 20:41
@MelvinBot MelvinBot requested review from tgolen and removed request for a team August 2, 2021 20:41
@tgolen
Copy link
Contributor

tgolen commented Aug 3, 2021

I'm just working on the last screenshot for iOS

@tgolen tgolen merged commit a4e40fe into Expensify:main Aug 3, 2021
@OSBotify
Copy link
Contributor

OSBotify commented Aug 3, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

OSBotify commented Aug 6, 2021

🚀 Deployed to staging in version: 1.0.82-8🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @francoisl in version: 1.0.83-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants