Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOU Error Handling, navigated back to Amount Page on error #4378

Merged
merged 3 commits into from
Aug 4, 2021

Conversation

Santhosh-Sellavel
Copy link
Collaborator

@Santhosh-Sellavel Santhosh-Sellavel commented Aug 2, 2021

@thienlnam

Details

Fixed Issues

#4130

Tests & QA Steps

  1. Create a new Request Money / Split
  2. Enter Amount 100,000,000 amount or more

##Handling
On Error will take the user back to the amount page, an appropriate error notification will be shown.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android - Kindly test it will work

Screenshots

Web

IOU_Error_Handling_Web.mov

Mobile Web

IOU_Error_Handling_mWeb.mov

Desktop

IOU_Error_Handling_Desktop.mov

iOS

IOU_Error_Handling_iOS.mov

@Santhosh-Sellavel
Copy link
Collaborator Author

@thienlnam translation needed for es

@thienlnam thienlnam self-requested a review August 2, 2021 22:09
@thienlnam
Copy link
Contributor

thienlnam commented Aug 3, 2021

Translations:

Invalid Amount > Monto no válido
Split amount does not equal total amount > La suma de las partes no equivale al monto total
Unexpected error, please try again later > Error inesperado, por favor inténtalo más tarde

@thienlnam
Copy link
Contributor

Updated the translations above ^

@Santhosh-Sellavel Santhosh-Sellavel marked this pull request as ready for review August 3, 2021 22:21
@Santhosh-Sellavel Santhosh-Sellavel requested a review from a team as a code owner August 3, 2021 22:21
@MelvinBot MelvinBot removed the request for review from a team August 3, 2021 22:21
@Santhosh-Sellavel Santhosh-Sellavel changed the title [WIP] IOU Error Handling, navigated back to Amount Page on error IOU Error Handling, navigated back to Amount Page on error Aug 3, 2021
@Santhosh-Sellavel
Copy link
Collaborator Author

@thienlnam Done check and let me know.

Copy link
Contributor

@thienlnam thienlnam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good! Just one small comment

src/pages/iou/IOUModal.js Show resolved Hide resolved
@thienlnam thienlnam merged commit 526aeb0 into Expensify:main Aug 4, 2021
@OSBotify
Copy link
Contributor

OSBotify commented Aug 4, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@Santhosh-Sellavel
Copy link
Collaborator Author

@thienlnam I didn’t remove methods yet

@thienlnam
Copy link
Contributor

@Santhosh-Sellavel That is my bad, accidentally merged - can you spin up another PR disabling eslint and removing the method?

@Santhosh-Sellavel
Copy link
Collaborator Author

@Santhosh-Sellavel That is my bad, accidentally merged - can you spin up another PR disabling eslint and removing the method?

Sure I'm On it.

@OSBotify
Copy link
Contributor

OSBotify commented Aug 6, 2021

🚀 Deployed to staging in version: 1.0.82-8🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @francoisl in version: 1.0.83-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants