Copy change for personal address to avoid drop addresses #4320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chiragsalian
approved these changes
Jul 30, 2021
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
100 tasks
|
🚀 Deployed to staging in version: 1.0.81-5🚀
|
|
🚀 Deployed to production in version: 1.0.82-7🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc. @MitchExpensify
Details
Explicitly call our personal addresses not to use PO boxes or drop addresses.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/171703
And Slack thread
Tests
Tests
Since it is difficult to test for Web-Secure related features in App locally, I've decided to simply :
QA Steps
Same than test steps except it will be :
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android