fix selected option is not highlighted #43093

tienifr · 2024-06-05T09:50:37Z

Details

Fixed Issues

$ #42583
PROPOSAL: #42583 (comment)

Tests

Precondition:

Workspace has a regular category, parent category and category in Parent: Child format.

Go to app
Go to + > Submit expense > Manual.
Proceed to confirmation page.
Click Category.
Select a regular category.
Click Category.
Search for the regular category via search field.
Note that the first item in the search result is highlighted.
Select a parent category (not the child category).
Repeat Step 7 to 8.
When parent category is selected, the first item in the search result will be highlighted when searching for it.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-06-05.at.17.03.12.mov

Android: mWeb Chrome

Screen.Recording.2024-06-05.at.17.00.50.mov

iOS: Native

Screen.Recording.2024-06-05.at.17.04.14.mov

iOS: mWeb Safari

Screen.Recording.2024-06-05.at.17.09.28.mov

MacOS: Chrome / Safari

Screen.Recording.2024-06-05.at.16.51.09.mov

MacOS: Desktop

Screen.Recording.2024-06-05.at.16.58.19.mov

melvin-bot · 2024-06-05T09:50:42Z

@Ollyws Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Ollyws · 2024-06-06T14:51:36Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

01_Android_Native.mp4

Android: mWeb Chrome

02_Android_Chrome.mp4

iOS: Native

03_iOS_Native.mp4

iOS: mWeb Safari

04_iOS_Safari.mp4

MacOS: Chrome / Safari

05_MacOS_Chrome.mp4

MacOS: Desktop

06_MacOS_Desktop.mp4

Ollyws

LGTM.

tienifr · 2024-06-14T02:54:09Z

@lakchote Can you help review this PR?

tienifr · 2024-06-19T02:56:47Z

Bump to review it @lakchote

dangrous · 2024-06-28T11:01:21Z

Okay I'm feeling a little confused - is it just me or does this have the same behavior on main? Did something else change recently?

(taking over the review from @lakchote)

lakchote · 2024-07-01T07:30:17Z

I was on parental leave @tienifr,

Thanks for taking this over @dangrous!

I'm unassigning myself from the review.

tienifr · 2024-07-02T10:36:39Z

In latest main, we have a new logic:

App/src/components/SelectionList/BaseSelectionList.tsx

Line 552 in 9fbbbfb

const newSelectedIndex =

that will auto focus on the first item if prevAllOptionsLength !== flattenedSections.allOptions.length so the bug cannot be reproduced. @Ollyws Can you help confirm?
Though the bug is not reproduced anymore, based on the RCA of this bug, I think we still need to make sure we only call selectedOptions,push(item) if that item is not added before:

App/src/components/SelectionList/BaseSelectionList.tsx

Lines 148 to 150 in 525ad6f

if (item.isSelected) {

selectedOptions.push(item);

}

@dangrous

dangrous · 2024-07-02T14:42:38Z

No problem!

@Ollyws and @tienifr - it definitely looks like this has been solved on main already:

Let me know if you agree, or if I'm testing incorrectly (using the steps above)

tienifr · 2024-07-02T14:51:41Z

@dangrous Yes, I still cannot reproduce the bug in the latest main. Just need the confirmation from @Ollyws

dangrous · 2024-07-03T09:56:05Z

Oops sorry I missed your comment @tienifr, I didn't mean to be pushy! Was working off of dodgy wifi.

So yeah, I'm fine with still pushing this change if we feel that it adds redundancy to keep things working! Let us know what you think @Ollyws

Ollyws · 2024-07-03T13:31:55Z

Though the bug is not reproduced anymore, based on the #42583 (comment) of this bug, I think we still need to make sure we only call selectedOptions,push(item) if that item is not added before:

Yeah I agree it still makes sense to add this change.

dangrous

Okay great. Approving! Thanks for your patience.

OSBotify · 2024-07-03T14:47:11Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-07-03T20:00:18Z

🚀 Deployed to staging by https://github.com/dangrous in version: 9.0.4-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-04T22:12:45Z

🚀 Cherry-picked to staging by https://github.com/tgolen in version: 9.0.4-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2024-07-10T10:55:11Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.5-13 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-15T20:18:26Z

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.6-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix selected option is not highlighted

6e28975

tienifr requested a review from a team as a code owner June 5, 2024 09:50

melvin-bot bot requested review from Ollyws and removed request for a team June 5, 2024 09:50

tienifr mentioned this pull request Jun 5, 2024

[C+ Checklist Needs Completion] [$250] Category - First item in the search result is not highlighted when parent category is selected #42583

Closed

6 tasks

Ollyws approved these changes Jun 6, 2024

View reviewed changes

melvin-bot bot requested a review from lakchote June 6, 2024 14:51

dangrous self-requested a review June 28, 2024 10:40

lakchote removed their request for review July 1, 2024 07:30

dangrous approved these changes Jul 3, 2024

View reviewed changes

dangrous merged commit cd72f1b into Expensify:main Jul 3, 2024
18 checks passed

github-actions bot mentioned this pull request Jul 3, 2024

Deploy Checklist: New Expensify 2024-07-03 #44782

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix selected option is not highlighted #43093

fix selected option is not highlighted #43093

tienifr commented Jun 5, 2024 •

edited

Loading

melvin-bot bot commented Jun 5, 2024

Ollyws commented Jun 6, 2024

Ollyws left a comment

tienifr commented Jun 14, 2024

tienifr commented Jun 19, 2024

dangrous commented Jun 28, 2024 •

edited

Loading

lakchote commented Jul 1, 2024

tienifr commented Jul 2, 2024

dangrous commented Jul 2, 2024

tienifr commented Jul 2, 2024

dangrous commented Jul 3, 2024

Ollyws commented Jul 3, 2024

dangrous left a comment

OSBotify commented Jul 3, 2024

OSBotify commented Jul 3, 2024

OSBotify commented Jul 4, 2024

OSBotify commented Jul 10, 2024

OSBotify commented Jul 15, 2024

fix selected option is not highlighted #43093

fix selected option is not highlighted #43093

Conversation

tienifr commented Jun 5, 2024 • edited Loading

Details

Fixed Issues

Tests

Precondition:

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jun 5, 2024

Ollyws commented Jun 6, 2024

Reviewer Checklist

Screenshots/Videos

Ollyws left a comment

Choose a reason for hiding this comment

tienifr commented Jun 14, 2024

tienifr commented Jun 19, 2024

dangrous commented Jun 28, 2024 • edited Loading

lakchote commented Jul 1, 2024

tienifr commented Jul 2, 2024

dangrous commented Jul 2, 2024

tienifr commented Jul 2, 2024

dangrous commented Jul 3, 2024

Ollyws commented Jul 3, 2024

dangrous left a comment

Choose a reason for hiding this comment

OSBotify commented Jul 3, 2024

OSBotify commented Jul 3, 2024

OSBotify commented Jul 4, 2024

OSBotify commented Jul 10, 2024

OSBotify commented Jul 15, 2024

tienifr commented Jun 5, 2024 •

edited

Loading

dangrous commented Jun 28, 2024 •

edited

Loading