Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[No QA] Fix crash #4297

Merged
merged 1 commit into from
Jul 29, 2021
Merged

[No QA] Fix crash #4297

merged 1 commit into from
Jul 29, 2021

Conversation

parasharrajat
Copy link
Member

Details

Follow up #4194

Fixed Issues

$ Crash

@parasharrajat parasharrajat requested a review from a team as a code owner July 29, 2021 05:47
@MelvinBot MelvinBot requested review from MonilBhavsar and removed request for a team July 29, 2021 05:47
@parasharrajat parasharrajat mentioned this pull request Jul 29, 2021
Merged
5 tasks
@parasharrajat
Copy link
Member Author

@MonilBhavsar This PR is very urgent and should go with #4194 on staging.

@MonilBhavsar MonilBhavsar merged commit 6f1b536 into Expensify:main Jul 29, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@marcaaron
Copy link
Contributor

@MonilBhavsar next time we need to CP something to staging I think we can add the CP Staging label. This PR must be sent to staging.

@marcaaron
Copy link
Contributor

Oh yeah but that label can only be applied before the merge happens.

@marcaaron marcaaron changed the title [NO QA] Fix crash [CP Staging] [NO QA] Fix crash Jul 29, 2021
@marcaaron marcaaron changed the title [CP Staging] [NO QA] Fix crash [CP Staging] Fix crash Jul 29, 2021
github-actions bot pushed a commit that referenced this pull request Jul 29, 2021
@MonilBhavsar
Merge pull request #4297 from parasharrajat/context-menu
be9d80d 
[NO QA] Fix crash

(cherry picked from commit 6f1b536)
This was referenced Jul 29, 2021
Closed
Closed
@marcaaron
Copy link
Contributor

JK this did not need to go to staging. Please ignore me.

@marcaaron
Copy link
Contributor

Sorry @MonilBhavsar you did everything right 😄

@marcaaron marcaaron changed the title [CP Staging] Fix crash Fix crash Jul 29, 2021
@parasharrajat parasharrajat changed the title Fix crash [No QA] Fix crash Jul 30, 2021
@OSBotify OSBotify mentioned this pull request Jul 30, 2021
Closed
100 tasks
@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.81-5🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Aug 6, 2021

🚀 Deployed to production in version: 1.0.82-7🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@parasharrajat parasharrajat deleted the context-menu branch November 20, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MonilBhavsar MonilBhavsar MonilBhavsar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@parasharrajat @OSBotify @marcaaron @MonilBhavsar