chore(bumped-ecommon-ver): Updated expensify-common version #4295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok seeing all the checks running now 🥳 Thank you for your patience on this one! |
AndrewGable
approved these changes
Jul 29, 2021
|
@Luke9389 - This is @mananjadhav's third try at this same PR, so I've reviewed the rest of this code. It looks great, so I am going to merge before your review 🚀 |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
Finally. Thanks for merging. Took more effort to merge the PR than to solve the bug 😝 |
|
Sorry about that @mananjadhav - Hopefully your next few PRs will be more smooth 😆 |
This was referenced Jul 30, 2021
|
🚀 Deployed to staging in version: 1.0.81-5🚀
|
|
🚀 Deployed to production in version: 1.0.82-7🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@AndrewGable Hopefully this should work!
Details
Fixed Issues
$ Fixes App/4229
Tests
QA Steps
[Yo (click here to see a cool cat)](https://c8.alamy.com/compes/ha11pc/cookie-cat-con-sombrero-de-cowboy-y-sun-glass-ha11pc.jpg)(without `)Tested On
Screenshots
Web
md-hyperlink-web-screencast.mp4
Mobile Web
md-hyperlink-mobile-web-screencast.mp4
Desktop
md-hyperlink-desktop-screencast.mp4
iOS
md-hyperlink-ios-screencast.mp4
Android
md-hyperlink-android-screencast.mp4