-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wrong amount is displayed when updating waypoint in offline #42833
Conversation
@akinwale Can you please take a look at this PR? |
@neil-marcellini Please assign me here so that I can complete the review here. Thanks. |
@neil-marcellini Trying to confirm what the ideal behaviour is. Should the amount be cleared (as shown in the video included here) which just leaves the value blank, or should Screen.Recording.2024-06-04.at.04.44.04.mp4 |
I think we should keep the current behavior that clear the amount. |
@neil-marcellini Can you please confirm the behavior above? Thanks. |
@neil-marcellini Please help to take a look at the comment above when you have a chance. Thanks |
I think it should be blank when the distance field is pending, as described in the expected behavior of the issue. We use to say TBD but decided it was unnecessary a while ago. |
Let's be sure to get a review from @deetergp before merging since he's assigned to the issue. |
@akinwale Please help to review again when you have a chance. Thanks. |
@akinwale Bump! |
Just tried to test but waypoints aren't loading for me for some reason. I'll re-test again in a few hours. |
Bump @akinwale |
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / Safari42833-web.mp4MacOS: Desktop |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.0.4-0 🚀
|
🚀 Cherry-picked to staging by https://github.com/tgolen in version: 9.0.4-5 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.5-13 🚀
|
🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.6-8 🚀
|
Details
Fix wrong amount is displayed when updating waypoint in offline
Fixed Issues
$ #42784
PROPOSAL:
Tests
Pending
Offline tests
Same as above
QA Steps
Pending
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Screen.Recording.2024-05-31.at.16.03.04.mov
Android: mWeb Chrome
Screen.Recording.2024-05-31.at.16.02.28.mov
iOS: Native
Screen.Recording.2024-05-31.at.16.05.20.mov
iOS: mWeb Safari
Screen.Recording.2024-05-31.at.16.03.46.mov
MacOS: Chrome / Safari
Screen.Recording.2024-05-30.at.18.16.20.mov
MacOS: Desktop
Screen.Recording.2024-05-31.at.16.07.12.mov