feat: empty ui for create flows

[tienifr]

Details

This PR adds illustrations to empty list for create flows:

• Split Expense
• Submit Expense
• Pay Someone

Fixed Issues

$ #42227
PROPOSAL: #42227 (comment)

Tests

1. Create a new account
2. Press FAB >> Submit expense
3. Enter any amount and navigate to participant selector page
4. Verify loading skeleton appears first
5. Verify illustrations appear if the selection list is empty
6. Verify referral banner disappears
7. Search for any contacts
8. Verify illustrations disappear
9. Verify referral banner appears
10. Repeat with other flows as mentioned in Details

• Verify that no errors appear in the JS console

Offline tests

NA

QA Steps

Note

Refer to iOS: mWeb Safari and MacOS: Chrome / Safari screenshots for the latest design.

1. Create a new account
2. Press FAB >> Submit expense
3. Enter any amount and navigate to participant selector page
4. Verify loading skeleton appears first
5. Verify illustrations appear if the selection list is empty
6. Search for any contacts
7. Verify illustrations disappear
8. Repeat with other flows as mentioned in Details

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

Screen.Recording.2024-07-24.at.16.17.14-compressed.mov

MacOS: Chrome / Safari

MacOS: Desktop

[melvin-bot]

@rayane-djouah Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[shawnborton]

From a copy perspective, it looks like we have an orphan in "number" - cc @jamesdeanexpensify

Thoughts on forcing a line break before "or" so the bottom line reads "or phone number" ?

[shawnborton]

Looks like the illustration is cut off on iOS:

[jamesdeanexpensify]

@shawnborton tagged ya here to get alignment.

[tienifr]

@shawnborton @dannymcclain I updated screenshots after resolving feedbacks. Also, this is what it looks like when keyboard is open and I don't think it looks good. What do you think it should be like?

[jamesdeanexpensify]

@danielrvidal we're going with the updated copy below as decided here, right?

Submit an expense
Submit to someone and get $250 when they become a customer.

Split an expense
Split with a friend and get $250 when they become a customer.

Pay someone
Pay anyone and get $250 when they become a customer.

[dubielzyk-expensify]

What do you think it should be like?

My take is that the illustration and text should ignore the keyboard and be centered vertically on the. That means that when the keyboard moves in it'll obscure parts of the text and illustration. But keen to hear what @Expensify/design thinks

[shawnborton]

Yup, I agree with @dubielzyk-expensify in that the keyboard would sit on top of the content in this case.

Also, I think we decided to only show the referral banner once you start seeing results in the contact list after searching? This way we aren't duplicating the same message from the empty state.

[dannymcclain]

My take is that the illustration and text should ignore the keyboard and be centered vertically
That means that when the keyboard moves in it'll obscure parts of the text and illustration.

Yup, I agree too.

[jamesdeanexpensify]

Just double checking - where should I confirm that we're updating to this copy? Thank you!

[danielrvidal]

@tienifr can you please make sure to update the copy and screenshots to reflect this comment from @jamesdeanexpensify.

That matches the copy here, where you can also find the Spanish copy as well.

[allroundexperts]

Lint failing @tienifr

[tienifr]

I'm updating the copies and handle the keyboard overlapping behavior. Will finish today.

[shawnborton]

Yes! Thank you so much Jon.

[tienifr]

Thank you @dubielzyk-expensify @shawnborton I'll try to update in a few hours

[tienifr]

@shawnborton @dubielzyk-expensify Let's check the following the result. Hopefully it's our expectation

web-resize.mp4

[dubielzyk-expensify]

Looooovely! Can we move the illustration up about 20-32px? It sits a bit low. Otherwise this is awesome work 😄 Thank you!

[tienifr]

Thanks for your feedback @dubielzyk-expensify. I updated

[shawnborton]

Looking good! Thanks for bearing with our feedback.

One small idea as I see this - should we slightly increase the horizontal padding of the empty state so that the text wraps in a more friendly way? Basically so that we can get "become..." to start on the second line, which might balance out how that sentence looks split across the two lines?

[dannymcclain]

One small idea as I see this - should we slightly increase the horizontal padding of the empty state so that the text wraps in a more friendly way?

I like that idea. I also wonder if instead of changing the padding, we just add a line break so it wraps exactly how we want it to?

[shawnborton]

True... we could definitely try that out and see what happens!

[tienifr]

@shawnborton @dannymcclain. Thanks for your suggestions. I updated the PR

[shawnborton]

Looks good!

[mountiny]

Thank you for the patience @tienifr lets be on a look out for any regressions

[mountiny]

given Shawn's approval I will move this ahead to avoid any merge conflicts

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.21-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by https://github.com/Beamanator in version: 9.0.21-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	failure ❌

[OSBotify]

🚀 Deployed to production by https://github.com/Beamanator in version: 9.0.21-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[shawnborton]

Hmm I am getting some jumpiness when the "not found" message appears under the search input - I thought we fixed that?

CleanShot.2024-08-28.at.12.30.09.mp4

[mountiny]

@tienifr Are you able to look into this one. Can you reproduce? It should have been fixed I believe