Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[No QA][Search v1] Create ReportListItem #42410
[No QA][Search v1] Create ReportListItem #42410
Changes from 12 commits
08d9b5a
6b69166
3adf6c6
091b791
15c67fe
8faa91e
fd497d3
66fa2bc
8dc6526
addc73e
f8cd746
7f3bb52
efb9d26
3f24116
2e1c4c1
6de2ab9
7a5b63f
66fc34c
8f12ccd
c673051
4e2942b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we use
SearchUtils.getSearchType(searchResults?.search);
instead of introducing a new functionThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This type guard allows to check the type of the item, and then we can use a specific item field to open the report.
SearchUtils.getSearchType(searchResults?.search);
won't determine an exact type of the item.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this empty line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to add the logic to display the correct button text. Let's see the design, the button text could be "Review", "Submit",...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now the only option is
view
, but I agree that we should be getting that from the API results.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have started to work on this a while ago and was explicitly told to wait, and the task is on
HOLD
so it should stayView
for now.We can fix buttons in a dedicated PR - I have a WIP draft open
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same above