Added Balance badge to the Settings page #4220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ready for review. |
|
@Jag96 Whenever you are ready, please review it. I have no more changes left to do. |
Jag96
suggested changes
Jul 28, 2021
src/components/Badge.js
Outdated
| /** Is success type */ | ||
| success: PropTypes.bool, | ||
|
|
||
| /** Is success type */ |
src/components/MenuItem.js
Outdated
|
|
||
| const propTypes = { | ||
| // Text to be shown as badge near the right end. |
There was a problem hiding this comment.
This comment should use block comments per style guide
src/styles/styles.js
Outdated
| * @param {Boolean} [isPressed] | ||
| * @returns {Object} | ||
| * @param {*} success | ||
| * @param {*} error |
There was a problem hiding this comment.
These should be {Boolean} right?
| }) => { | ||
| const walletBalance = numberFormat( | ||
| userWallet.availableBalance, |
There was a problem hiding this comment.
It looks like if the user has no availableBalance, this can be $NaN, so I think we want a fallback of 0 here.
|
@Jag96 Updated. |
|
Gentle bump @Jag96 Changes are done. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
This was referenced Jul 29, 2021
|
🚀 Deployed to staging in version: 1.0.81-5🚀
|
|
🚀 Deployed to production in version: 1.0.82-7🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @stitesExpensify
Details
Fixed Issues
$ #4171
Tests | QA Steps
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android