fix implement recently used currencies #41834

DylanDylann · 2024-05-08T12:00:03Z

Details

Fixed Issues

$ #34874
PROPOSAL: #34874 (comment)

Tests

Test 1

Open app.
Open any workspace and create a manual expense with any currency.
Open the above workspace and click on "Submit expense" then "Manual".
On the amount page, click on the current.
Verify that the currency in step 2 is displayed in "Recents" section.

Test 2

Open app.
Open FAB then "Submit expense", choose "Manual" then submit an expense with any user.
Open FAB then "Submit expense", choose "Manual".
On the amount page, click on the current.
Verify that the currency in step 2 is displayed in "Recents" section.

Verify that no errors appear in the JS console.

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-05-09.at.11.24.44.mov

Android: mWeb Chrome

Screen.Recording.2024-05-09.at.11.05.22.mov

iOS: Native

Screen.Recording.2024-05-09.at.11.16.32.mov

iOS: mWeb Safari

Screen.Recording.2024-05-09.at.11.02.21.mov

MacOS: Chrome / Safari

Screen.Recording.2024-05-09.at.10.50.39.mov

MacOS: Desktop

output.mp4

melvin-bot · 2024-05-08T12:00:08Z

@getusha Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

getusha · 2024-05-12T14:39:37Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ x I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-08-14.at.12.54.00.in.the.afternoon.mov

Android: mWeb Chrome

Screen.Recording.2024-08-14.at.12.34.04.in.the.afternoon.mov

iOS: Native

Screen.Recording.2024-08-14.at.12.45.25.in.the.afternoon.mov

iOS: mWeb Safari

Screen.Recording.2024-08-14.at.12.41.35.in.the.afternoon.mov

MacOS: Chrome / Safari

Screen.Recording.2024-09-06.at.12.33.16.in.the.afternoon.mov

Screen.Recording.2024-08-14.at.11.59.43.in.the.morning.mov

MacOS: Desktop

Screen.Recording.2024-09-06.at.1.06.55.in.the.afternoon.mov

getusha · 2024-05-14T15:54:30Z

@DylanDylann the currency is not showing in recents if i don't change the default one, could you check?

Screen.Recording.2024-05-14.at.6.53.43.in.the.evening.mov

DylanDylann · 2024-05-15T11:06:37Z

@getusha The recentlyUsedCurrencies are stored for each policy. I see in your video, in the 2nd creating expense, we cannot define the policy so there is no recentlyUsedCurrencies.

DylanDylann · 2024-05-17T02:33:16Z

@getusha Do you have any feedback about comment here?

getusha · 2024-05-19T12:18:24Z

@DylanDylann could you please expand your statement?

it means we can't have recently used currencies on a p2p requests?

DylanDylann · 2024-05-20T07:49:05Z

we can't have recently used currencies on a p2p requests?

Yes, I think so

getusha · 2024-05-20T14:49:06Z

@thienlnam i think we should handle this case too, wdyt?

DylanDylann · 2024-05-22T23:44:57Z

@thienlnam Do you have any feedback about comment?

DylanDylann · 2024-05-28T10:52:42Z

@thienlnam Can you help check this?

thienlnam · 2024-05-28T21:52:38Z

Just came back from OOO, I also think we should support it for P2P payments - is there a specific reason we wouldn't? There are still some cases in the BE that need to be updated to actually update the recently used currency but we should support it in the FE

DylanDylann · 2024-05-31T16:02:21Z

@thienlnam

There are still some cases in the BE that need to be updated

Can you provide the structure of the recently used currencies that will be returned by the backend? This will allow me to make the necessary changes on the frontend accordingly.

thienlnam · 2024-05-31T18:10:10Z

It will be the same as before as mentioned here #34874 (comment)

DylanDylann · 2024-06-01T00:38:05Z

@thienlnam I mean with the P2p request, which key do we use to get the recently used currencies? In case the workspace, we use policyID.

DylanDylann · 2024-06-04T17:10:13Z

@thienlnam Can you check my question?

thienlnam · 2024-06-06T16:01:32Z

Ah good question, the current plan is to prefix the onyx key with the personal policy ID so it remains in that format for P2P requests

DylanDylann · 2024-06-12T09:16:53Z

@getusha I addressed this #41834 (comment), please help review the PR.

getusha · 2024-06-13T08:06:36Z

@DylanDylann ts check is failing

getusha · 2024-06-13T08:12:09Z

@DylanDylann it's not working for me, is there any pre-requisite could you check again?

Screen.Recording.2024-06-13.at.11.10.44.in.the.morning.mov

getusha · 2024-06-18T12:35:25Z

Bump @DylanDylann, we also have a conflict and ts check failing.

DylanDylann · 2024-06-18T12:36:40Z

Thanks for bump. I missed the notification. I will try to update asap

DylanDylann · 2024-08-20T09:05:36Z

@getusha I updated PR to fix the conflict and applied your suggestion codes.

lets update the testing steps since you need to have 2 recently selected currencies for the Recents section to appear.

Updated test steps.

should we add recently used currencies section when submitting expense from the global create?

This has already been handled and I updated test steps to cover this case.

DylanDylann · 2024-08-22T08:46:13Z

@getusha In case you miss it, PR is ready to review again.

getusha · 2024-08-25T10:59:53Z

This has already been handled and I updated test steps to cover this case.

@DylanDylann i am not able to see the recents section when i submit from global action

Screen.Recording.2024-08-25.at.1.58.29.in.the.afternoon.mov

DylanDylann · 2024-08-26T00:57:44Z

@getusha I noticed in your video that you created an expense from the global action, which was then sent to a workspace. As a result, the recently used currency applies to the target workspace, not the personal workspace.

To apply the recently used currency to your personal workspace, you can create and submit the expense directly to an individual user instead of a workspace.

src/components/CurrencySelectionList/index.tsx

DylanDylann · 2024-09-09T07:08:03Z

@getusha PR is updated

getusha

Looks good, one minor comment

getusha · 2024-09-10T08:48:33Z

src/libs/actions/IOU.ts

+        // Add currency to optimistic policy recently used currencies when a participant is a workspace
+        const optimisticPolicyRecentlyUsedCurrencies = isPolicyExpenseChat ? Policy.buildOptimisticPolicyRecentlyUsedCurrencies(currency) : [];


do we need this condition? and i think it's better to rename the function

You are correct, I removed that condition and renamed the function

mountiny

Small NAB comments

src/libs/actions/IOU.ts

src/components/CurrencySelectionList/index.tsx

thienlnam · 2024-09-10T19:10:33Z

src/components/CurrencySelectionList/index.tsx

-                ? [{data: filteredCurrencies.filter((currency) => currency.isSelected)}, {data: filteredCurrencies.filter((currency) => !currency.isSelected)}]
-                : [{data: filteredCurrencies}];
+        if (shouldDisplayRecentlyOptions) {
+            const cutPolicyRecentlyUsedCurrencyOptions = policyRecentlyUsedCurrencyOptions.slice(0, CONST.IOU.MAX_RECENT_REPORTS_TO_SHOW);


You can remove this - this is limited in the BE and will only grow to 5

I think we still need this logic in case of offline mode.

If that's the case, we should handle that in buildOptimisticRecentlyUsedCurrencies so we don't have to keep this logic so anywhere that uses / shows the recently used currency option can just use it directly

I updated PR

thienlnam

Great, thanks!

OSBotify · 2024-09-12T10:51:46Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-09-12T21:37:24Z

🚀 Deployed to staging by https://github.com/thienlnam in version: 9.0.34-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-09-13T22:45:06Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.0.34-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix implement recently used currencies

2207db4

DylanDylann requested a review from a team as a code owner May 8, 2024 12:00

melvin-bot bot requested review from getusha and removed request for a team May 8, 2024 12:00

fix lint

0309bbf

DylanDylann mentioned this pull request May 9, 2024

[$500] [MEDIUM] [Feature Request] Currency selection screen should have "Recents" at top #34874

Closed

6 tasks

DylanDylann added 2 commits June 12, 2024 15:24

fix merge main

6a1b428

fix handle p2p request

cfa6401

fix merge main

fb70418

resolve conflicts

d582c63

fix lint

f02e36a

DylanDylann added 4 commits August 27, 2024 18:55

merge main

4db1b2c

merge main

59aef43

use nvp_recentlyUsedCurrencies for all

3077b27

fix type

2125f71

getusha reviewed Sep 6, 2024

View reviewed changes

src/components/CurrencySelectionList/index.tsx Outdated Show resolved Hide resolved

fix: use Array.isArray check

381d5b9

getusha reviewed Sep 10, 2024

View reviewed changes

DylanDylann added 2 commits September 10, 2024 19:55

fix rename buildOptimisticRecentlyUsedCurrencies function

c4bc961

fix rename variable

cdeafbd

getusha approved these changes Sep 10, 2024

View reviewed changes

melvin-bot bot requested a review from thienlnam September 10, 2024 14:25

mountiny previously approved these changes Sep 10, 2024

View reviewed changes

src/libs/actions/IOU.ts Outdated Show resolved Hide resolved

src/libs/actions/IOU.ts Outdated Show resolved Hide resolved

thienlnam reviewed Sep 10, 2024

View reviewed changes

fix rename variable

6acba93

DylanDylann dismissed mountiny’s stale review via 6acba93 September 11, 2024 08:58

DylanDylann added 2 commits September 12, 2024 14:07

fix update buildOptimisticRecentlyUsedCurrencies

d9d65fa

fix lint

1f7939c

thienlnam approved these changes Sep 12, 2024

View reviewed changes

thienlnam merged commit ef6a64c into Expensify:main Sep 12, 2024
15 checks passed

github-actions bot mentioned this pull request Sep 12, 2024

Deploy Checklist: New Expensify 2024-09-12 #49139

Closed

30 tasks

		// Add currency to optimistic policy recently used currencies when a participant is a workspace
		const optimisticPolicyRecentlyUsedCurrencies = isPolicyExpenseChat ? Policy.buildOptimisticPolicyRecentlyUsedCurrencies(currency) : [];

fix implement recently used currencies #41834

fix implement recently used currencies #41834

Conversation

DylanDylann commented May 8, 2024 • edited Loading

Details

Fixed Issues

Tests

Test 1

Test 2

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented May 8, 2024

getusha commented May 12, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

getusha commented May 14, 2024

DylanDylann commented May 15, 2024

DylanDylann commented May 17, 2024

getusha commented May 19, 2024 • edited Loading

DylanDylann commented May 20, 2024

getusha commented May 20, 2024

DylanDylann commented May 22, 2024

DylanDylann commented May 28, 2024

thienlnam commented May 28, 2024

DylanDylann commented May 31, 2024

thienlnam commented May 31, 2024

DylanDylann commented Jun 1, 2024

DylanDylann commented Jun 4, 2024

thienlnam commented Jun 6, 2024

DylanDylann commented Jun 12, 2024

getusha commented Jun 13, 2024

getusha commented Jun 13, 2024

getusha commented Jun 18, 2024

DylanDylann commented Jun 18, 2024

DylanDylann commented Aug 20, 2024

DylanDylann commented Aug 22, 2024

getusha commented Aug 25, 2024

DylanDylann commented Aug 26, 2024

DylanDylann commented Sep 9, 2024

getusha left a comment

Choose a reason for hiding this comment

getusha Sep 10, 2024

Choose a reason for hiding this comment

DylanDylann Sep 10, 2024

Choose a reason for hiding this comment

getusha Sep 10, 2024

Choose a reason for hiding this comment

mountiny left a comment

Choose a reason for hiding this comment

thienlnam Sep 10, 2024

Choose a reason for hiding this comment

DylanDylann Sep 11, 2024

Choose a reason for hiding this comment

thienlnam Sep 11, 2024

Choose a reason for hiding this comment

DylanDylann Sep 12, 2024

Choose a reason for hiding this comment

thienlnam left a comment

Choose a reason for hiding this comment

OSBotify commented Sep 12, 2024

OSBotify commented Sep 12, 2024

OSBotify commented Sep 13, 2024

DylanDylann commented May 8, 2024 •

edited

Loading

getusha commented May 12, 2024 •

edited

Loading

getusha commented May 19, 2024 •

edited

Loading