Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent invalid configuration between location and JE selection #41638

Merged
merged 46 commits into from
May 31, 2024
Merged

Prevent invalid configuration between location and JE selection #41638

merged 46 commits into from
May 31, 2024

Commits on May 4, 2024

  1. fix: lock the toggle for disabling location when the account selected… 

    … is not JE
    Hayata Suenaga committed May 4, 2024
    Configuration menu
    Copy the full SHA
    faa4eb7 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2024

  1. fix the boolean condition

    Hayata Suenaga committed May 5, 2024
    Configuration menu
    Copy the full SHA
    43d57ac View commit details
    Browse the repository at this point in the history

  2. chore: filter out account options depending on whether the location t… 

    …racking is enabled or not
    Hayata Suenaga committed May 5, 2024
    Configuration menu
    Copy the full SHA
    102c2bf View commit details
    Browse the repository at this point in the history

Commits on May 6, 2024

  1. chore: lock the toggle button when the location import should be off

    Hayata Suenaga committed May 6, 2024
    Configuration menu
    Copy the full SHA
    056c362 View commit details
    Browse the repository at this point in the history

  2. chore: add a todo comment not to forget to change the description text

    Hayata Suenaga committed May 6, 2024
    Configuration menu
    Copy the full SHA
    e74a7ae View commit details
    Browse the repository at this point in the history

Commits on May 10, 2024

  1. Merge branch 'main' into hayata-do-not-allow-invalid-location-account… 

    …-combo
    Hayata Suenaga committed May 10, 2024
    Configuration menu
    Copy the full SHA
    d3be0c3 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2024

  1. fix: wrong conditional statement

    Hayata Suenaga committed May 11, 2024
    Configuration menu
    Copy the full SHA
    add3daf View commit details
    Browse the repository at this point in the history

  2. change const name and don't force in-active state

    Hayata Suenaga committed May 11, 2024
    Configuration menu
    Copy the full SHA
    c771c51 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2024

  1. fix: use existing value to determine if the location is enabled or not

    Hayata Suenaga committed May 14, 2024
    Configuration menu
    Copy the full SHA
    21aef13 View commit details
    Browse the repository at this point in the history

  2. fix: don't use conditional rendering

    Hayata Suenaga committed May 14, 2024
    Configuration menu
    Copy the full SHA
    01d10e5 View commit details
    Browse the repository at this point in the history

  3. fix: the ordering of items

    Hayata Suenaga committed May 14, 2024
    Configuration menu
    Copy the full SHA
    286980f View commit details
    Browse the repository at this point in the history

  4. fix: the ordering of items

    Hayata Suenaga committed May 14, 2024
    Configuration menu
    Copy the full SHA
    a9f76f4 View commit details
    Browse the repository at this point in the history

  5. don't disable the switch for the location import if the location is a… 

    …lready enabled so that the user can disable it
    Hayata Suenaga committed May 14, 2024
    Configuration menu
    Copy the full SHA
    b9cf433 View commit details
    Browse the repository at this point in the history

  6. chore: remove todo comments

    Hayata Suenaga committed May 14, 2024
    Configuration menu
    Copy the full SHA
    3c1b841 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2024

  1. update the UI copy

    Hayata Suenaga committed May 15, 2024
    Configuration menu
    Copy the full SHA
    bcecada View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into hayata-do-not-allow-invalid-location-account… 

    …-combo
    Hayata Suenaga committed May 15, 2024
    Configuration menu
    Copy the full SHA
    30cfcac View commit details
    Browse the repository at this point in the history

  3. style: get config value from the destructuring statement

    Hayata Suenaga committed May 15, 2024
    Configuration menu
    Copy the full SHA
    dd891b7 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into hayata-do-not-allow-invalid-location-account… 

    …-combo
    Hayata Suenaga committed May 15, 2024
    Configuration menu
    Copy the full SHA
    4774590 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2024

  1. fix: update the spanish translation

    Hayata Suenaga committed May 20, 2024
    Configuration menu
    Copy the full SHA
    9b08271 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2024

  1. fix: use isSwitchOn to decide if the admin should be allowed to tog… 

    …gle the switch
    Hayata Suenaga committed May 23, 2024
    Configuration menu
    Copy the full SHA
    6ba9dc4 View commit details
    Browse the repository at this point in the history

  2. fix: move the hint text to the entity select page

    Hayata Suenaga committed May 23, 2024
    Configuration menu
    Copy the full SHA
    14943e7 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2024

  1. fix: issue with the footer component

    Hayata Suenaga committed May 24, 2024
    Configuration menu
    Copy the full SHA
    ac3e90b View commit details
    Browse the repository at this point in the history

  2. chore: remove unnecessary hint text

    Hayata Suenaga committed May 24, 2024
    Configuration menu
    Copy the full SHA
    023c313 View commit details
    Browse the repository at this point in the history

Commits on May 27, 2024

  1. chore: fix the style of hint texts when there is no account to display

    Hayata Suenaga committed May 27, 2024
    Configuration menu
    Copy the full SHA
    cdb176a View commit details
    Browse the repository at this point in the history

  2. chore: don't display the hint text when there is misconfiguration

    Hayata Suenaga committed May 27, 2024
    Configuration menu
    Copy the full SHA
    0688088 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2024

  1. fix: delete unnecessary UI text

    Hayata Suenaga committed May 28, 2024
    Configuration menu
    Copy the full SHA
    f5e4c04 View commit details
    Browse the repository at this point in the history

Commits on May 29, 2024

  1. fix: add back the footer

    Hayata Suenaga committed May 29, 2024
    Configuration menu
    Copy the full SHA
    a0845eb View commit details
    Browse the repository at this point in the history

  2. chore: revert the commit for changing the hint display behavior in lo… 

    …cations page
    Hayata Suenaga committed May 29, 2024
    Configuration menu
    Copy the full SHA
    805b67e View commit details
    Browse the repository at this point in the history

  3. chore: change the hint text behavior on the taxes page

    Hayata Suenaga committed May 29, 2024
    Configuration menu
    Copy the full SHA
    a313d7a View commit details
    Browse the repository at this point in the history

  4. fix: the display text

    Hayata Suenaga committed May 29, 2024
    Configuration menu
    Copy the full SHA
    427ca57 View commit details
    Browse the repository at this point in the history

  5. chore: update the text

    Hayata Suenaga committed May 29, 2024
    Configuration menu
    Copy the full SHA
    5925a85 View commit details
    Browse the repository at this point in the history

  6. fix: check if the company card export destination is vendor bill & cr… 

    …eate additional variable
    Hayata Suenaga committed May 29, 2024
    Configuration menu
    Copy the full SHA
    948b665 View commit details
    Browse the repository at this point in the history

  7. chore: add the word "checks"

    Hayata Suenaga committed May 29, 2024
    Configuration menu
    Copy the full SHA
    911d494 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2024

  1. remove outdated conditions

    @s77rt
    s77rt committed May 30, 2024
    Configuration menu
    Copy the full SHA
    a421cdd View commit details
    Browse the repository at this point in the history

Commits on May 31, 2024

  1. Merge pull request #42883 from s77rt/s77rt-do-not-allow-invalid-locat… 

    …ion-account-combo

Remove outdated conditions
    Hayata Suenaga authored May 31, 2024
    Configuration menu
    Copy the full SHA
    15452e6 View commit details
    Browse the repository at this point in the history

  2. fix: add back the check to see if the error should be shown

    Hayata Suenaga committed May 31, 2024
    Configuration menu
    Copy the full SHA
    7cd358e View commit details
    Browse the repository at this point in the history

  3. Merge branch 'qbo-freeze-branch' into hayata-do-not-allow-invalid-loc… 

    …ation-account-combo
    Hayata Suenaga committed May 31, 2024
    Configuration menu
    Copy the full SHA
    f769502 View commit details
    Browse the repository at this point in the history

  4. remove mistype

    Hayata Suenaga committed May 31, 2024
    Configuration menu
    Copy the full SHA
    5d5d2cd View commit details
    Browse the repository at this point in the history

  5. chore: replace with accountDescription

    Hayata Suenaga committed May 31, 2024
    Configuration menu
    Copy the full SHA
    5ffc623 View commit details
    Browse the repository at this point in the history

  6. remove isLocationEnabled check

    Hayata Suenaga committed May 31, 2024
    Configuration menu
    Copy the full SHA
    52a8ac0 View commit details
    Browse the repository at this point in the history

  7. Fix footer styles

    @s77rt
    s77rt committed May 31, 2024
    Configuration menu
    Copy the full SHA
    362167d View commit details
    Browse the repository at this point in the history

  8. Update src/pages/workspace/accounting/qbo/export/QuickbooksOutOfPocke… 

    …tExpenseEntitySelectPage.tsx
    @s77rt
    s77rt authored May 31, 2024
    Configuration menu
    Copy the full SHA
    c97ffd3 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'qbo-freeze-branch' into hayata-do-not-allow-invalid-loc… 

    …ation-account-combo
    @lakchote
    lakchote committed May 31, 2024
    Configuration menu
    Copy the full SHA
    da6232d View commit details
    Browse the repository at this point in the history

  10. fix prettier

    @lakchote
    lakchote committed May 31, 2024
    Configuration menu
    Copy the full SHA
    715f3da View commit details
    Browse the repository at this point in the history

  11. Merge pull request #42921 from s77rt/s77rt-do-not-allow-invalid-locat… 

    …ion-account-combo-ts-fix

Fix entity select page footer styles
    @lakchote
    lakchote authored May 31, 2024
    Configuration menu
    Copy the full SHA
    f8a9176 View commit details
    Browse the repository at this point in the history

  12. chore: update outdated spanish copy

    Hayata Suenaga committed May 31, 2024
    Configuration menu
    Copy the full SHA
    a3729d4 View commit details
    Browse the repository at this point in the history