-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tax fields for distance requests #41379
Closed
teneeto
wants to merge
28
commits into
Expensify:main
from
teneeto:feature/31673/add-tax-fields-for-distance-requests
Closed
Add tax fields for distance requests #41379
teneeto
wants to merge
28
commits into
Expensify:main
from
teneeto:feature/31673/add-tax-fields-for-distance-requests
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
50 tasks
…3/add-tax-fields-for-distance-requests
…ub.com:teneeto/Expensify into feature/31673/add-tax-fields-for-distance-requests
…3/add-tax-fields-for-distance-requests
…3/add-tax-fields-for-distance-requests
6 tasks
…3/add-tax-fields-for-distance-requests
…ub.com:teneeto/Expensify into feature/31673/add-tax-fields-for-distance-requests
…3/add-tax-fields-for-distance-requests
…3/add-tax-fields-for-distance-requests
…3/add-tax-fields-for-distance-requests
50 tasks
Closing for #42342 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR adds Support for tax tracking when offline.
Fixed Issues
$: 31673
PROPOSAL: issuecomment
Tests
Submit expense
(money request) flow.Expectation: Both the tax amount and tax rate fields cannot be modified - no right icon and the tax row is not interactive.
Expectation: Both the tax amount and tax rate fields cannot be modified - no right icon and the tax row is not interactive.
Offline tests
Submit expense
(money request) flow.Expectation: Both the tax amount and tax rate fields cannot be modified - no right icon and the tax row is not interactive.
Expectation: Both the tax amount and tax rate fields cannot be modified - no right icon and the tax row is not interactive.
QA Steps
Submit expense
(money request) flow.Expectation: Both the tax amount and tax rate fields cannot be modified - no right icon and the tax row is not interactive.
Expectation: Both the tax amount and tax rate fields cannot be modified - no right icon and the tax row is not interactive.
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
MacOS: Chrome / Safari
iOS: Native
Android: Native
Android: mWeb Chrome
iOS: mWeb Safari
MacOS: Desktop