Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add employeeList to local policy after creation #3947

Merged
merged 1 commit into from
Jul 9, 2021
Merged

Add employeeList to local policy after creation #3947

merged 1 commit into from
Jul 9, 2021

Conversation

rdjuric
Copy link
Contributor

@rdjuric rdjuric commented Jul 9, 2021

Details

Adds a missing field (employeeList) to our Onyx.merge after creating a new policy.

Fixed Issues

$ #3923

Tests

  1. Open the app
  2. Click on the LHN and then on New Workspace
  3. Choose a name and create the Workspace
  4. Click on People on the left side
  5. Your profile shows up on the list
  6. Click on the checkbox close to ASSIGNEE
  7. The app doesn't crash

QA Steps

Same as above

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

web.mov

Mobile Web

mWeb.mp4

Desktop

desktop.mov

iOS

iOS.mp4

Android

android.mp4

@rdjuric rdjuric requested a review from a team as a code owner July 9, 2021 07:00
@rdjuric rdjuric changed the title add employeeList to local policy after creation Add employeeList to local policy after creation Jul 9, 2021
@MelvinBot MelvinBot requested review from NikkiWines and removed request for a team July 9, 2021 07:00
@mountiny mountiny self-requested a review July 9, 2021 16:21
mountiny
mountiny approved these changes Jul 9, 2021
View reviewed changes
Copy link
Contributor

@mountiny mountiny left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested! Well spotted @rdjuric!

NikkiWines
NikkiWines approved these changes Jul 9, 2021
View reviewed changes
Copy link
Contributor

@NikkiWines NikkiWines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works well! :shipit:

@NikkiWines NikkiWines merged commit 0be2f95 into Expensify:main Jul 9, 2021
@OSBotify
Copy link
Contributor

OSBotify commented Jul 9, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Jul 9, 2021
Closed
23 tasks
@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.77-5🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NikkiWines NikkiWines NikkiWines approved these changes

@mountiny mountiny mountiny approved these changes

Assignees

@rdjuric rdjuric

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rdjuric @OSBotify @NikkiWines @mountiny