When navigating to the same report, don't reset the navigation state #3945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdjuric
commented
Jul 9, 2021
src/libs/Navigation/CustomActions.js
Outdated
| const rootState = navigationRef.current.getRootState(); | ||
| const activeReportID = rootState.routes[0].state.routes[0].params.reportID; | ||
| const activeReportID = lodashGet(rootState, 'routes[0].state.routes[0].params.reportID', '') |
There was a problem hiding this comment.
This doesn't look very good but should be safe. Maybe a better idea would be making this a getActiveReport(rootState) function that searches for a route of type === 'drawer' and get's the reportID from it?
Not sure.
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
23 tasks
|
🚀 Deployed to production in version: 1.0.77-5🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Check if we're attempting to navigate to the active report. If we are, reveals the report and do not reset the navigation state.
Fixed Issues
$ #3893
Tests
QA Steps
Tested On
Screenshots
Web
web.mov
Mobile Web
Desktop
desktop.mov
iOS
Android
I'm having a hard time adding videos for mobile as it isn't receiving the notifications. I tested on mobile by emulating the behavior of a notification click somewhere in a modal.