Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct styling for timeRow for other user in 1:1 chat #3942

Merged
merged 1 commit into from
Jul 9, 2021
Merged

Correct styling for timeRow for other user in 1:1 chat #3942

merged 1 commit into from
Jul 9, 2021

Conversation

parasharrajat
Copy link
Member

Details

Small change for #3883 (comment).

Tests | QA Steps

  1. Open Any conversation on E.cash.
  2. Other user's Local Time should be visible over the composer.
  3. It should trim if the name of another user is bigger than the screen.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

localhost_8080_r_68438375

@parasharrajat parasharrajat requested a review from a team as a code owner July 9, 2021 01:50
@MelvinBot MelvinBot requested review from TomatoToaster and removed request for a team July 9, 2021 01:50
@parasharrajat parasharrajat changed the title [NO QA] Correct styling for timeRow for other user in 1:1 chat Correct styling for timeRow for other user in 1:1 chat Jul 9, 2021
TomatoToaster
TomatoToaster approved these changes Jul 9, 2021
View reviewed changes
Copy link
Contributor

@TomatoToaster TomatoToaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That guy's got a crazy name. Nice work 👍🏾

@TomatoToaster TomatoToaster merged commit 2db53ec into Expensify:main Jul 9, 2021
@OSBotify
Copy link
Contributor

OSBotify commented Jul 9, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Jul 9, 2021
Closed
23 tasks
@parasharrajat parasharrajat mentioned this pull request Jul 13, 2021
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.77-5🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@rdjuric rdjuric mentioned this pull request Jul 15, 2021
Closed
@parasharrajat parasharrajat deleted the timezone branch November 20, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomatoToaster TomatoToaster TomatoToaster approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@parasharrajat @OSBotify @TomatoToaster