Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepend website form with https:// #3938

Merged
merged 1 commit into from
Jul 9, 2021
Merged

Conversation

roryabraham
Copy link
Contributor

Details

Prepends the website form input on the VBA company step with https://

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/170004

Tests / QA Steps (Web only)

  1. Go to /bank-account/company
  2. Verify that the text input for the company website is pre-populated with https://
  3. Verify that when you select the input and start typing, that https:// isn't automatically overwritten.

Tests / QA Steps (other platforms)

On other platforms, the VBA flow is not yet readily accessible.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

image

Mobile Web

Desktop

iOS

Android

@roryabraham roryabraham requested a review from a team as a code owner July 9, 2021 00:03
@roryabraham roryabraham self-assigned this Jul 9, 2021
@MelvinBot MelvinBot requested review from jasperhuangg and removed request for a team July 9, 2021 00:03
@jasperhuangg jasperhuangg merged commit a5f8dac into main Jul 9, 2021
@jasperhuangg jasperhuangg deleted the Rory-DefaultValueForWebsite branch July 9, 2021 12:11
@OSBotify
Copy link
Contributor

OSBotify commented Jul 9, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.77-5🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants