[No QA] Fix Comment on issues GH action.

[parasharrajat]

Details

It's a follow up PR for #3771 (comment)

Tests

QA Steps

Tested On

• Web
• Mobile Web
• Desktop
• iOS
• Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

[parasharrajat]

@roryabraham this is an attempt to fix the break.

1. Currently I have added logging to see the real issue. And Noticed that PRList is String[] so we need to convert to a number[] for matching. I follow strictly matching (===).
2. I found one interesting fact that isStagingDeployLocked returns currently opened StagingDeployIssue issue with LockDeploycash label. But we don't want to get that. Instead, we should pick the StagingDeployIssue which was active when PR was merged. Any idea, how can I get that?

[roryabraham]

Instead, we should pick the StagingDeployIssue which was active when PR was merged. Any idea, how can I get that?

Unfortunately, I don't think there's any really easy way to do it. Maybe something like this pseudocode:

const mergedAt = PR.merged_at;
const allStagingDeployCashIssues = getAllStagingDeployCashIssues().sortBy('newestToOldest');
let stagingDeployCash = null;
for (let issue of allStagingDeployCashIssues) {
    if (issue.created < mergedAt) {
        // This is the first StagingDeployCash created before this PR was merged.
        // Therefore it was the one that was active when the PR was merged.
        stagingDeployCash = issue;
        break;
    }
}

[parasharrajat]

🚀 Deployed to staging in version: test🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[parasharrajat]

Update: I have fixed the core issue which broke the GH action in the first place. Now I am doing changes related to #3937 (comment) comment.

To test the Changes I will use my old PR #3771 and one more with CP label. Please ignore the Comments like #3937 (comment).

Thank you.

[roryabraham]

@parasharrajat Did you forget to push your changes here? Let us know when this is ready for review? I think it's still using the non-existent export called GithubUtils.GITHUB_REPOSITORY

[parasharrajat]

Yeah, I am doing the last few changes to get the correct StagingDeployIssue and then I will push those changes all along.

[parasharrajat]

@roryabraham Updated and tested on #3581. Seems to work fine.
I have tried to minimize the Github API calls to a minimum best of my knowledge.

[roryabraham]

I think 30 per page is the default, right?

[parasharrajat]

yeah

[parasharrajat]

Updated

[NikkiWines]

👍

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging in version: 1.0.77-6🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production in version: 1.0.79-4🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅