Update Enable Payments terms page with updated terms #3879
Conversation
|
Dang, this looks amazing Joe - nice work! Everything looks pretty good to me. One small thing I noticed that isn't your fault but I would love to have fixed: there is a big white gap above the bottom-docked green button that shouldn't be there... Basically the bottom button component should really just look like this: Lemme know if that makes sense. |
|
@shawnborton yup that makes sense! I've removed those top margins:
|
|
Nice, looks good! |
|
🚀 Deployed to staging in version: 1.0.81-8🚀
|
|
@Jag96 Sorry, didn't get to this in time. Was on my To Do list for today. |
|
@marcaaron no worries, feel free to leave a review and if there's any follow-ups I can take care of them |
| super(props); | ||
| this.toggleSection = this.toggleSection.bind(this); | ||
| this.state = { | ||
| isExpanded: this.props.isExpanded, |
There was a problem hiding this comment.
I didn't see where we are passing this prop and think maybe this should just be false?
There was a problem hiding this comment.
True, we aren't currently using that prop value so I can just remove it and update the initial state to be false here
|
🚀 Deployed to production in version: 1.0.82-7🚀
|
|
I am tagging this PR to highlight an issue fixed here. All conditions in ternary expressions or left-hand operands on conditional renders, should be boolean. This PR is one of the PRs that uses conditional render with string operands, hence I am tagging it here for the contributors to check. We've also updated the item in the checklist with this PR to avoid this issue in the future. |
@marcaaron @shawnborton will you please review this?
Details
This PR updates the existing terms page with the approved terms content
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/167278
Tests
Review the terms page and confirm it matches the mockups from https://github.com/Expensify/Expensify/issues/167278.
The easiest way to get to the Terms Page without going through the entire OnFido flow is to update the following lines locally:
+button and selectingNew ChatQA Steps
N/A
Tested On
Screenshots
Mobile
Web/Desktop