-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move the position of checkmark in WS Invite Page #38218
Move the position of checkmark in WS Invite Page #38218
Conversation
@ishpaul777 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
As per the checklist, tagging @Expensify/design for the slight design change in Workspace Invite Page. This is done as per https://docs.google.com/document/d/1gk3xqOs7epMbUrSSiX8K7YcqfPLVgqEos0sf-D-GMDA/edit#bookmark=id.lwxqh44gqm2d |
Reviewer Checklist
Screenshots/VideosAndroid: NativeRecord_2024-03-13-19-37-41.mp4Android: mWeb ChromeRecord_2024-03-13-19-15-09.mp4iOS: NativeScreen.Recording.2024-03-13.at.7.09.20.PM.moviOS: mWeb SafariScreen.Recording.2024-03-13.at.7.02.04.PM.movScreen.Recording.2024-03-13.at.6.56.49.PM.movMacOS: Chrome / SafariScreen.Recording.2024-03-13.at.6.56.49.PM.movMacOS: DesktopScreen.Recording.2024-03-13.at.6.43.15.PM.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, just waiting for the chekclist
@shubham1206agra Can you please add videos for all platforms |
@ishpaul777 Do we need them as this is a fairly simple change? |
i usually only skip any videos when platform is not afftected at all, for example a change in specific platform files, rest i'll let @mountiny clarify.. |
Can you show me the "Before" screenshot too? I'm not quite sure what this fixed, so I want to make sure I am understanding that first. |
@shubham1206agra lets add web, ios native and android mweb |
@shawnborton Before screenshot. |
Ah okay, cool. I think that's fine and matches the design doc... but I have a feeling we're eventually going to make this view match the exact table style view we already have in Workspace settings? Either way, the adjustments look good to me. |
Thank you for checking! @ishpaul777 can you please proceed with the checklist? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
|
I am also done with screenshots. |
Co-authored-by: Carlos Martins <luacmartins@gmail.com> Co-authored-by: Ishpaul Singh <104348397+ishpaul777@users.noreply.github.com>
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/luacmartins in version: 1.4.53-0 🚀
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 1.4.53-2 🚀
|
Details
Fixed Issues
$ #35717
Tests
Offline tests
Same as Tests
QA Steps
Same as Tests
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop