-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix - Don't show RBR on the LHN for transaction threads with violations if the report has already been reimbursed/settled #37767
Merged
cead22
merged 12 commits into
Expensify:main
from
FitseTLT:fix-showing-RBR-for-settled-transaction
Mar 21, 2024
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
20a754b
hide RBR for settled requests
FitseTLT ca74d99
updated based on comments
FitseTLT 9a0386b
Merge branch 'main' into fix-showing-RBR-for-settled-transaction
FitseTLT 3f7a361
took the condition into doesTransactionThreadHaveViolations
FitseTLT 0e9bd7f
Merge branch 'main' into fix-showing-RBR-for-settled-transaction
FitseTLT dc222a1
Merge branch 'main' into fix-showing-RBR-for-settled-transaction
FitseTLT 233883d
updated to shouldDisplayTransactionThreadViolations function
FitseTLT 983b8f7
update to use shouldDisplayTransactionThreadViolations
FitseTLT adc09a2
reverted unnecessary change
FitseTLT 0d112b6
reverted comment
FitseTLT 384d183
fix based on comments
FitseTLT f9f8bb2
Merge branch 'main' into fix-showing-RBR-for-settled-transaction
FitseTLT File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Later, we added more condition (approved reports, not only reimbursed/settled) to hide RBR on the LHN for transaction threads.
#45230