Create WorkspaceTagsPage #37621
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,144 @@ | ||
| import type {StackScreenProps} from '@react-navigation/stack'; | ||
| import React, {useMemo, useState} from 'react'; | ||
| import {View} from 'react-native'; | ||
| import {withOnyx} from 'react-native-onyx'; | ||
| import type {OnyxEntry} from 'react-native-onyx'; | ||
| import HeaderWithBackButton from '@components/HeaderWithBackButton'; | ||
| import Icon from '@components/Icon'; | ||
| import * as Expensicons from '@components/Icon/Expensicons'; | ||
| import * as Illustrations from '@components/Icon/Illustrations'; | ||
| import ScreenWrapper from '@components/ScreenWrapper'; | ||
| import SelectionList from '@components/SelectionList'; | ||
| import TableListItem from '@components/SelectionList/TableListItem'; | ||
| import Text from '@components/Text'; | ||
| import WorkspaceEmptyStateSection from '@components/WorkspaceEmptyStateSection'; | ||
| import useLocalize from '@hooks/useLocalize'; | ||
| import useTheme from '@hooks/useTheme'; | ||
| import useThemeStyles from '@hooks/useThemeStyles'; | ||
| import useWindowDimensions from '@hooks/useWindowDimensions'; | ||
| import * as PolicyUtils from '@libs/PolicyUtils'; | ||
| import type {CentralPaneNavigatorParamList} from '@navigation/types'; | ||
| import AdminPolicyAccessOrNotFoundWrapper from '@pages/workspace/AdminPolicyAccessOrNotFoundWrapper'; | ||
| import PaidPolicyAccessOrNotFoundWrapper from '@pages/workspace/PaidPolicyAccessOrNotFoundWrapper'; | ||
| import ONYXKEYS from '@src/ONYXKEYS'; | ||
| import type SCREENS from '@src/SCREENS'; | ||
| import type * as OnyxTypes from '@src/types/onyx'; | ||
|
|
||
| type PolicyForList = { | ||
| value: string; | ||
| text: string; | ||
| keyForList: string; | ||
| isSelected: boolean; | ||
| rightElement: React.ReactNode; | ||
| }; | ||
|
|
||
| type WorkspaceTagsOnyxProps = { | ||
| /** Collection of tags attached to a policy */ | ||
| policyTags: OnyxEntry<OnyxTypes.PolicyTagList>; | ||
| }; | ||
|
|
||
| type WorkspaceTagsPageProps = WorkspaceTagsOnyxProps & StackScreenProps<CentralPaneNavigatorParamList, typeof SCREENS.WORKSPACE.TAGS>; | ||
|
|
||
| function WorkspaceTagsPage({policyTags, route}: WorkspaceTagsPageProps) { | ||
| const {isSmallScreenWidth} = useWindowDimensions(); | ||
| const styles = useThemeStyles(); | ||
| const theme = useTheme(); | ||
| const {translate} = useLocalize(); | ||
| const [selectedTags, setSelectedTags] = useState<Record<string, boolean>>({}); | ||
| const policyTagLists = useMemo(() => PolicyUtils.getTagLists(policyTags), [policyTags]); | ||
| const tagList = useMemo<PolicyForList[]>( | ||
| () => | ||
| policyTagLists | ||
| .map((policyTagList) => | ||
| Object.values(policyTagList.tags).map((value) => ({ | ||
| value: value.name, | ||
| text: value.name, | ||
| keyForList: value.name, | ||
waterim marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| isSelected: !!selectedTags[value.name], | ||
| rightElement: ( | ||
| <View style={styles.flexRow}> | ||
| <Text style={[styles.disabledText, styles.alignSelfCenter]}> | ||
| {value.enabled ? translate('workspace.common.enabled') : translate('workspace.common.disabled')} | ||
| </Text> | ||
| <View style={[styles.p1, styles.pl2]}> | ||
| <Icon | ||
| src={Expensicons.ArrowRight} | ||
| fill={theme.icon} | ||
| /> | ||
| </View> | ||
| </View> | ||
| ), | ||
| })), | ||
| ) | ||
| .flat(), | ||
| [policyTagLists, selectedTags, styles.alignSelfCenter, styles.disabledText, styles.flexRow, styles.p1, styles.pl2, theme.icon, translate], | ||
| ); | ||
|
|
||
| const toggleTag = (tag: PolicyForList) => { | ||
| setSelectedTags((prev) => ({ | ||
| ...prev, | ||
| [tag.value]: !prev[tag.value], | ||
| })); | ||
| }; | ||
|
|
||
| const toggleAllTags = () => { | ||
| const isAllSelected = tagList.every((tag) => !!selectedTags[tag.value]); | ||
| setSelectedTags(isAllSelected ? {} : Object.fromEntries(tagList.map((item) => [item.value, true]))); | ||
| }; | ||
|
|
||
| const getCustomListHeader = () => ( | ||
| <View style={[styles.flex1, styles.flexRow, styles.justifyContentBetween, styles.pl3, styles.pr9]}> | ||
| <Text style={styles.searchInputStyle}>{translate('common.name')}</Text> | ||
| <Text style={[styles.searchInputStyle, styles.textAlignCenter]}>{translate('statusPage.status')}</Text> | ||
| </View> | ||
| ); | ||
|
|
||
| return ( | ||
| <AdminPolicyAccessOrNotFoundWrapper policyID={route.params.policyID}> | ||
| <PaidPolicyAccessOrNotFoundWrapper policyID={route.params.policyID}> | ||
| <ScreenWrapper | ||
| includeSafeAreaPaddingBottom={false} | ||
| style={[styles.defaultModalContainer]} | ||
| testID={WorkspaceTagsPage.displayName} | ||
| shouldShowOfflineIndicatorInWideScreen | ||
| > | ||
| <HeaderWithBackButton | ||
| icon={Illustrations.Tag} | ||
| title={translate('workspace.common.tags')} | ||
| shouldShowBackButton={isSmallScreenWidth} | ||
| /> | ||
|
Comment on lines
+99
to
+109
There was a problem hiding this comment. Hey, I have a question related to this change. Every workspace page uses the There was a problem hiding this comment. I don't think the new pages do, e.g. WorkspaceMembersPage, WorkspaceCategoriesPage There was a problem hiding this comment. The I'm using this wrapper to fix multiple not found views, and part of the PR is making the above page use the wrapper. So what is the aim of the There was a problem hiding this comment. Hmm interesting case, maybe we should be using There was a problem hiding this comment. We probably have to think it over as currently, we have three different wrappers for workspaces, and we don't have clear guidelines on when to use which one. There was a problem hiding this comment. Yea, that makes sense. I'll create an issue for it. There was a problem hiding this comment. Those wrappers also break the not-found views. Going to e.g. https://staging.new.expensify.com/workspace/dssaddssdaads/categories` we see duplicated not found (that's what is the scope of the other issue) and after pressing the back button we see another ones... |
||
| <View style={[styles.ph5, styles.pb5]}> | ||
| <Text style={[styles.textNormal, styles.colorMuted]}>{translate('workspace.tags.subtitle')}</Text> | ||
| </View> | ||
| {tagList.length ? ( | ||
| <SelectionList | ||
| canSelectMultiple | ||
| sections={[{data: tagList, indexOffset: 0, isDisabled: false}]} | ||
| onCheckboxPress={toggleTag} | ||
| onSelectRow={() => {}} | ||
waterim marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| onSelectAll={toggleAllTags} | ||
| showScrollIndicator | ||
| ListItem={TableListItem} | ||
| customListHeader={getCustomListHeader()} | ||
| listHeaderWrapperStyle={[styles.ph9, styles.pv3, styles.pb5]} | ||
| /> | ||
| ) : ( | ||
| <WorkspaceEmptyStateSection | ||
| title={translate('workspace.tags.emptyTags.title')} | ||
| icon={Illustrations.EmptyStateExpenses} | ||
| subtitle={translate('workspace.tags.emptyTags.subtitle')} | ||
| /> | ||
| )} | ||
| </ScreenWrapper> | ||
| </PaidPolicyAccessOrNotFoundWrapper> | ||
| </AdminPolicyAccessOrNotFoundWrapper> | ||
| ); | ||
| } | ||
|
|
||
| WorkspaceTagsPage.displayName = 'WorkspaceTagsPage'; | ||
|
|
||
| export default withOnyx<WorkspaceTagsPageProps, WorkspaceTagsOnyxProps>({ | ||
| policyTags: { | ||
| key: ({route}) => `${ONYXKEYS.COLLECTION.POLICY_TAGS}${route.params.policyID}`, | ||
| }, | ||
| })(WorkspaceTagsPage); | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coming from #38663.
We add a
isDisabledflag to take care of the behavior when deleting a tag offline. :)