Add notification preference to simplified report object #3746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuwenmemon
requested review from
thienlnam
and removed request for
thienlnam and
MonilBhavsar
thienlnam
approved these changes
Jun 24, 2021
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
This was referenced Jun 25, 2021
|
🚀 Deployed to staging in version: 1.0.73-4🚀
|
|
🚀 Deployed to production in version: 1.0.74-0🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@thienlnam please review
Details
Just start adding the
notificationPreferenceto thesimplifiedReportObjectfor a user if they have one set on a default chat room.Fixed Issues
For https://github.com/Expensify/Expensify/issues/161781
Tests
notificationPreferenceto a report for a user, made sure that the particular preference was shown in the report object in the local storage for the app:notificationPreferenceQA Steps
Tested On