Fix NotificationResponse race condition

[roryabraham]

Details

For a while, the callback for the NotificationResponse event (i.e: when a push notification is tapped) was usually not being executed. The previous code falsely assumed that the NotificationResponse callback would happen while the app was still in the background, because it is when the event occurs. It did rarely happen this way, because there was a race condition in play between these two responses to this event:

1. The OS natively brings the app to the foreground.
2. The JavaScript callback is executed.

The native OS response is almost always faster, so by the time the JS callback executes, the app is in the foreground and we skipped the callback. Instead, we'll only skip the callback for PushReceived events that happen when the app is in the foreground.

Fixed Issues

Fixes (partial) https://github.com/Expensify/Expensify/issues/158830

Tests / QA Steps

0. (iOS dev only) Launch the app on a physical iPhone device. (SO)
1. Log into the app on mobile as user A.
2. Log into the app on another platform as user B.
3. As user A, open a chat between A and a user other than B.
4. As user A, background the mobile app
5. As user B, send a message to user A.
6. Verify that a push notification appears for user A.
7. Tap on the notification. Verify that the app opens to the chat between user A and user B (a different chat than you had open when you backgrounded the app).

Tested On

• Web
• Mobile Web
• Desktop
• iOS
• Android

Screenshots

Web

Mobile Web

Desktop

iOS

RPReplay_Final1624493296.MP4

Android

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging in version: 1.0.73-4🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production in version: 1.0.74-0🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅