-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix displaying error message when image has been downloaded #37316
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The result looks good! But I still need a clarification for the comments.
Reviewer Checklist
Screenshots/VideosAndroid: Native37316.Android.mp4Android: mWeb Chrome37316.mWeb-Chrome.mp4iOS: Native37316.iOS.mp4iOS: mWeb Safari37316.mWeb-Safari.mp4MacOS: Chrome / Safari37316.Web.mp4MacOS: Desktop37316.Desktop.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Friendly bump @thienlnam |
Ah thanks for the bump - missed this |
Going to generate a build so we can verify with a real ios device first |
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet, it's working for me - thanks!
@thienlnam looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/thienlnam in version: 1.4.48-0 🚀
|
🚀 Deployed to production by https://github.com/roryabraham in version: 1.4.48-0 🚀
|
Details
Fixed Issues
$ #36870
PROPOSAL: #36870 (comment)
Tests
Offline tests
N/A
QA Steps
Same as in the Tests section.
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Screenrecorder-2024-02-27-21-40-02-710.mp4
Android: mWeb Chrome
Screenrecorder-2024-02-27-21-29-14-786.0.mp4
iOS: Native
Screen.Recording.2024-02-26.at.21.57.58.mov
iOS: mWeb Safari
Untitled.mov
MacOS: Chrome / Safari
Screen.Recording.2024-02-27.at.21.16.22.mov
MacOS: Desktop
Screen.Recording.2024-02-27.at.21.19.42.mov