Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix app returns to previous thread when scrubbing video in thread #37270

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Fix app returns to previous thread when scrubbing video in thread #37270

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/components/VideoPlayer/BaseVideoPlayer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,12 @@ function BaseVideoPlayer({

return (
<>
<View style={style}>
{/* We need to wrap the video component in a component that will catch unhandled pointer events. Otherwise, these
events will bubble up the tree, and it will cause unexpected press behavior. */}
<PressableWithoutFeedback
accessibilityRole="button"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coming from #45619 (comment), we should not add this prop to avoid console error "validateDOMNesting(...): cannot appear as a descendant of"

style={[styles.cursorDefault, style]}
>
<Hoverable>
{(isHovered) => (
<View style={[styles.w100, styles.h100]}>
Expand Down Expand Up @@ -241,7 +246,7 @@ function BaseVideoPlayer({
</View>
)}
</Hoverable>
</View>
</PressableWithoutFeedback>
<VideoPopoverMenu
isPopoverVisible={isPopoverVisible}
hidePopover={hidePopoverMenu}
Expand Down
Loading