-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix optimistic created report shows infinite skeleton loading #37269
Conversation
} | ||
|
||
fetchReportIfNeeded(); | ||
}, [isHydrated]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change was added to solve an issue when creating a new workspace room, Chat Report is shown as the room name.
That's because the data is not ready yet here and the report name becomes Chat Report.
https://github.com/Expensify/App/blob/main/src/libs/actions/Report.ts#L552-L556
Even after this PR is merged, we will still have an extra OpenReport request because the report data is not immediately available. App/src/pages/home/ReportScreen.js Lines 355 to 362 in 668df99
One way to fix it is by using |
Details
This PR makes the report screen renders immediately even when the report data is not available yet and we have a logic to overwrite the report data when the report Onyx is empty.
Fixed Issues
$ #35906
$ #37247
$ #37234
PROPOSAL:
Tests
Same as QA Steps
Offline tests
A. Same as QA Steps
B.
QA Steps
A.
B.
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
New.Expensify.Dev.1.mp4
Screen.Recording.2024-02-27.at.17.53.51.mov
Android: mWeb Chrome
Screen.Recording.2024-02-27.at.16.05.34.mov
Screen.Recording.2024-02-27.at.17.51.05.mov
iOS: Native
Screen.Recording.2024-02-27.at.15.59.42.mov
Screen.Recording.2024-02-27.at.17.48.30.mov
iOS: mWeb Safari
Screen.Recording.2024-02-27.at.15.54.32.mov
Screen.Recording.2024-02-27.at.17.50.35.mov
MacOS: Chrome / Safari
Screen.Recording.2024-02-27.at.15.48.19.mov
Screen.Recording.2024-02-27.at.17.45.28.mov
MacOS: Desktop
Screen.Recording.2024-02-27.at.15.50.39.mov
Screen.Recording.2024-02-27.at.17.46.05.mov