fix: Video - Invalid file is downloaded when downloading video. #37163

Krishna2323 · 2024-02-23T22:52:56Z

Details

Fixed Issues

$ #37092
PROPOSAL: #37092 (comment)

Tests

Go to any chat
Send a video
Right click on the video > Download & verify video is downloaded
Click on the expand button in the video preview and click download icon in the attachment model , verify video is downloaded
Click the three dots in the video controller and select download, verify video is downloaded

Verify that no errors appear in the JS console

Offline tests

Go to any chat
Send a video
Right click on the video > Download & verify video is downloaded
Click on the expand button in the video preview and click download icon in the attachment model , verify video is downloaded
Click the three dots in the video controller and select download, verify video is downloaded

QA Steps

Go to any chat
Send a video
Right click on the video > Download & verify video is downloaded
Click on the expand button in the video preview and click download icon in the attachment model , verify video is downloaded
Click the three dots in the video controller and select download, verify video is downloaded

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android_native_1.mp4

Android: mWeb Chrome

android_chrome.mp4

iOS: Native

ios_native.mp4

iOS: mWeb Safari

ios_safari.mp4

MacOS: Chrome / Safari

web_chrome.mp4

MacOS: Desktop

desktop_app_2.mp4

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

melvin-bot · 2024-02-23T22:53:01Z

@s77rt Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

s77rt

Apply suggestion and revert the rest

src/libs/fileDownload/FileUtils.ts

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

s77rt · 2024-02-23T23:05:43Z

Please revert the other changes

This reverts commit b82fb45.

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

Krishna2323 · 2024-02-23T23:54:40Z

@s77rt, do you have any clue about this error? Why does it happen when downloading from popover menu? When we download from message context menu the request is sent to https://www.expensify.com, but when downloading from video popover menu it sends request to https://dev.new.expensify.com:8082. It only happens on desktop app.

bug_url.mp4

s77rt · 2024-02-24T00:33:21Z

I'm not sure I can reproduce that bug. Can you please look into the native bug as well? On native it seems that status.url is different than that of web and this makes getPathFromURL crashes

App/src/components/VideoPlayerContexts/VideoPopoverMenuContext.js

Line 30 in 1366fb7

const sourceURI = `/${Url.getPathFromURL(status.uri)}`;

github-actions · 2024-02-24T01:42:10Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/37163/index.html	❌ FAILED ❌
	The QR code can't be generated, because the iOS build failed
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/37163/NewExpensify.dmg	https://37163.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

Krishna2323 · 2024-02-24T19:49:08Z

@s77rt, yes, the bug also exists on native devices as well as the desktop app. After some digging, I found that in the code below, we don't use tryResolveUrlFromApiRoot before passing the url to fileDownload. Passing the URL after using tryResolveUrlFromApiRoot solves the issue on all platforms.

App/src/components/VideoPlayerContexts/VideoPopoverMenuContext.js

Lines 28 to 33 in d0d77c1

    
           const downloadAttachment = useCallback(() => { 
        
               currentVideoPlayerRef.current.getStatusAsync().then((status) => { 
        
                   const sourceURI = `/${Url.getPathFromURL(status.uri)}`; 
        
                   fileDownload(sourceURI); 
        
               }); 
        
           }, [currentVideoPlayerRef]);

s77rt · 2024-02-24T20:01:03Z

@Krishna2323 On web the download should start on the same tab, using tryResolveUrlFromApiRoot may break that

Krishna2323 · 2024-02-24T20:05:47Z

@s77rt no it won't, we use tryResolveUrlFromApiRoot for all other file urls also. In the code below we use tryResolveUrlFromApiRoot which is used in download option in the comment context menu. I tested on web.

App/src/libs/fileDownload/getAttachmentDetails.ts

Lines 23 to 31 in d0d77c1

    
           const sourceURL = tryResolveUrlFromApiRoot(html.match(SOURCE_REGEX)?.[1] ?? ''); 
        
           const imageURL = IS_IMAGE_TAG ? tryResolveUrlFromApiRoot(html.match(PREVIEW_SOURCE_REGEX)?.[1] ?? '') : null; 
        
           const previewSourceURL = IS_IMAGE_TAG ? imageURL : sourceURL; 
        
           const originalFileName = html.match(ORIGINAL_FILENAME_REGEX)?.[1] ?? null; 
        
           // Update the image URL so the images can be accessed depending on the config environment 
        
           return { 
        
               previewSourceURL, 
        
               sourceURL,

Same for video/image attachment modal download option:

App/src/components/Attachments/AttachmentCarousel/extractAttachmentsFromReport.js

Lines 21 to 25 in d0d77c1

    
           if (name === 'video') { 
        
               const splittedUrl = attribs[CONST.ATTACHMENT_SOURCE_ATTRIBUTE].split('/'); 
        
               attachments.unshift({ 
        
                   reportActionID: null, 
        
                   source: tryResolveUrlFromApiRoot(attribs[CONST.ATTACHMENT_SOURCE_ATTRIBUTE]),

s77rt · 2024-02-24T20:15:09Z

@Krishna2323 Please test on all platforms, if it works push the changes

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

Krishna2323 · 2024-02-24T21:17:01Z

@s77rt, you were right it opens a new tab in web, first when I tried passing /${Url.getPathFromURL(status.uri)} to tryResolveUrlFromApiRoot, it worked for all platforms except android and now when I pass status.uri to tryResolveUrlFromApiRoot it opens new tab on web.

s77rt · 2024-02-24T21:22:49Z

The source should be kept relative then. Can you check why status.uri is different on web and native? On native it's already relative and extracting a path from a relative url does not work

Krishna2323 · 2024-02-25T20:26:36Z

@s77rt, the source we pass to Video component seems to be consistent everywhere, it seems that getStatusAsync returns relative path in native. WDYT we should do here? should be use a state for the url?

Krishna2323 · 2024-02-25T20:42:19Z

I tested using the source directly (setting state in VideoPopoverMenuContextProvider) and it works fine on all platforms.

s77rt · 2024-02-25T21:34:45Z

Can you try tryResolveUrlFromApiRoot followed by getPathFromURL. That why we always pass a valid a url.

Krishna2323 · 2024-02-25T22:43:25Z

@s77rt, that won't work on native devices because in native devices we need full path instead of just the path.

s77rt · 2024-02-25T23:15:11Z

I tested using the source directly (setting state in VideoPopoverMenuContextProvider) and it works fine on all platforms.

Why would that make a difference? On web we still need to use the path only

Krishna2323 · 2024-02-25T23:36:03Z

@s77rt, because we already use tryResolveUrlFromApiRoot for sources.

From here we get for attachment download button and we also pass it to video player context menu:

App/src/components/Attachments/AttachmentCarousel/extractAttachmentsFromReport.js

Line 25 in 56bda00

source: tryResolveUrlFromApiRoot(attribs[CONST.ATTACHMENT_SOURCE_ATTRIBUTE]),

And from VideoRenderer (Preview) also:

App/src/components/HTMLEngineProvider/HTMLRenderers/VideoRenderer.tsx

Line 19 in 56bda00

const sourceURL = tryResolveUrlFromApiRoot(attrHref);

s77rt · 2024-02-25T23:44:58Z

I think we can use currentlyPlayingURL from usePlaybackContext hook. ~~On native it have the correct url, on web it's null due to another bug. Let's fix that bug and use that value~~

Edit: No bug here.

s77rt · 2024-02-26T00:10:09Z

src/components/VideoPlayerContexts/VideoPopoverMenuContext.js

    const downloadAttachment = useCallback(() => {
        currentVideoPlayerRef.current.getStatusAsync().then((status) => {
-            const sourceURI = `/${Url.getPathFromURL(status.uri)}`;
+            const sourceURI = tryResolveUrlFromApiRoot(status.uri);
            fileDownload(sourceURI);
        });
    }, [currentVideoPlayerRef]);


const downloadAttachment = useCallback(() => fileDownload(addEncryptedAuthTokenToURL(currentlyPlayingURL)), [currentlyPlayingURL]);

This should do it. Please test on all platforms

Add the auth token only if the url does not start with blob: or file:

const downloadAttachment = useCallback(() => { const sourceURI = currentlyPlayingURL.startsWith('blob:') || currentlyPlayingURL.startsWith('file:') ? currentlyPlayingURL : addEncryptedAuthTokenToURL(currentlyPlayingURL); fileDownload(sourceURI); }, [currentlyPlayingURL]);

s77rt · 2024-02-26T00:26:15Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

mweb-chrome.mov

iOS: Native

I can't download videos on iOS but I think it's related to my simulator or settings as I can't download photos either

iOS: mWeb Safari

mweb-safari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

s77rt · 2024-02-26T01:26:25Z

@Krishna2323 Once you complete the tests and adding the screenshots / videos, please tag me

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

Krishna2323 · 2024-02-26T04:38:26Z

@s77rt, I tested on all platforms, works well. Screenshots are also added.

s77rt · 2024-02-26T04:52:44Z

@Krishna2323 Please remove step 1 and step 5 from the testing steps, and change step 7 to:

Click the three dots in the video controller and select download, verify video is downloaded

Krishna2323 · 2024-02-26T04:54:37Z

Done.

s77rt · 2024-02-26T05:03:07Z

@Krishna2323 You removed the wrong step, please double check

s77rt · 2024-02-26T05:05:17Z

Also please make the requested change on the last step

Krishna2323 · 2024-02-26T05:08:18Z

Sorry for that, I updated wrong step, Updated.

s77rt · 2024-02-26T05:18:23Z

Thank you!

fix: Video - Invalid file is downloaded when downloading video. (cherry picked from commit 2509631)

…ng-37163-1 🍒 Cherry pick PR #37163 to staging 🍒

OSBotify · 2024-02-26T18:38:09Z

🚀 Deployed to staging by https://github.com/deetergp in version: 1.4.43-19 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

deetergp · 2024-02-26T19:06:15Z

This is been CPed to staging and works 👍

Screen.Recording.2024-02-26.at.11.03.38.AM.mov

OSBotify · 2024-02-26T20:57:44Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.43-20 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix: Video - Invalid file is downloaded when downloading video.

b82fb45

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

Krishna2323 requested a review from a team as a code owner February 23, 2024 22:52

melvin-bot bot requested review from s77rt and removed request for a team February 23, 2024 22:52

s77rt suggested changes Feb 23, 2024

View reviewed changes

src/libs/fileDownload/FileUtils.ts Outdated Show resolved Hide resolved

minor refactor and comment update.

0de3817

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

Krishna2323 added 2 commits February 24, 2024 04:39

Revert "fix: Video - Invalid file is downloaded when downloading video."

d013155

This reverts commit b82fb45.

minor fix.

2f3da03

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

francoisl added the Ready To Build label Feb 24, 2024

Merge branch 'Expensify:main' into krishna2323/issue/37092

683cff8

fix: download issue on desktop & native devices.

4e68e2f

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

s77rt suggested changes Feb 26, 2024

View reviewed changes

fix failing video downloads on native.

4e54e81

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

s77rt approved these changes Feb 26, 2024

View reviewed changes

melvin-bot bot requested a review from deetergp February 26, 2024 05:18

shahinyan11 mentioned this pull request Feb 26, 2024

FIx downloading video crash #37122

Merged

50 tasks

deetergp approved these changes Feb 26, 2024

View reviewed changes

deetergp merged commit 2509631 into Expensify:main Feb 26, 2024
18 of 19 checks passed

OSBotify pushed a commit that referenced this pull request Feb 26, 2024

Merge pull request #37163 from Krishna2323/krishna2323/issue/37092

e462e07

fix: Video - Invalid file is downloaded when downloading video. (cherry picked from commit 2509631)

os-botify bot mentioned this pull request Feb 26, 2024

🍒 Cherry pick PR #37163 to staging 🍒 #37220

Merged

deetergp added a commit that referenced this pull request Feb 26, 2024

Merge pull request #37220 from Expensify/puneetlath-cherry-pick-stagi…

1d2ac2f

…ng-37163-1 🍒 Cherry pick PR #37163 to staging 🍒

github-actions bot mentioned this pull request Feb 26, 2024

Deploy Checklist: New Expensify 2024-02-19 #36820

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Video - Invalid file is downloaded when downloading video. #37163

fix: Video - Invalid file is downloaded when downloading video. #37163

Krishna2323 commented Feb 23, 2024 •

edited

Loading

melvin-bot bot commented Feb 23, 2024

s77rt left a comment

s77rt commented Feb 23, 2024

Krishna2323 commented Feb 23, 2024

s77rt commented Feb 24, 2024

github-actions bot commented Feb 24, 2024

Krishna2323 commented Feb 24, 2024 •

edited

Loading

s77rt commented Feb 24, 2024

Krishna2323 commented Feb 24, 2024 •

edited

Loading

s77rt commented Feb 24, 2024

Krishna2323 commented Feb 24, 2024

s77rt commented Feb 24, 2024

Krishna2323 commented Feb 25, 2024

Krishna2323 commented Feb 25, 2024

s77rt commented Feb 25, 2024

Krishna2323 commented Feb 25, 2024

s77rt commented Feb 25, 2024

Krishna2323 commented Feb 25, 2024

s77rt commented Feb 25, 2024 •

edited

Loading

s77rt Feb 26, 2024

s77rt Feb 26, 2024

s77rt Feb 26, 2024

s77rt commented Feb 26, 2024 •

edited

Loading

s77rt commented Feb 26, 2024

Krishna2323 commented Feb 26, 2024

s77rt commented Feb 26, 2024

Krishna2323 commented Feb 26, 2024

s77rt commented Feb 26, 2024

s77rt commented Feb 26, 2024

Krishna2323 commented Feb 26, 2024

s77rt commented Feb 26, 2024

OSBotify commented Feb 26, 2024

deetergp commented Feb 26, 2024

OSBotify commented Feb 26, 2024

fix: Video - Invalid file is downloaded when downloading video. #37163

fix: Video - Invalid file is downloaded when downloading video. #37163

Conversation

Krishna2323 commented Feb 23, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Feb 23, 2024

s77rt left a comment

Choose a reason for hiding this comment

s77rt commented Feb 23, 2024

Krishna2323 commented Feb 23, 2024

s77rt commented Feb 24, 2024

github-actions bot commented Feb 24, 2024

Krishna2323 commented Feb 24, 2024 • edited Loading

s77rt commented Feb 24, 2024

Krishna2323 commented Feb 24, 2024 • edited Loading

s77rt commented Feb 24, 2024

Krishna2323 commented Feb 24, 2024

s77rt commented Feb 24, 2024

Krishna2323 commented Feb 25, 2024

Krishna2323 commented Feb 25, 2024

s77rt commented Feb 25, 2024

Krishna2323 commented Feb 25, 2024

s77rt commented Feb 25, 2024

Krishna2323 commented Feb 25, 2024

s77rt commented Feb 25, 2024 • edited Loading

s77rt Feb 26, 2024

Choose a reason for hiding this comment

s77rt Feb 26, 2024

Choose a reason for hiding this comment

s77rt Feb 26, 2024

Choose a reason for hiding this comment

s77rt commented Feb 26, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

s77rt commented Feb 26, 2024

Krishna2323 commented Feb 26, 2024

s77rt commented Feb 26, 2024

Krishna2323 commented Feb 26, 2024

s77rt commented Feb 26, 2024

s77rt commented Feb 26, 2024

Krishna2323 commented Feb 26, 2024

s77rt commented Feb 26, 2024

OSBotify commented Feb 26, 2024

deetergp commented Feb 26, 2024

OSBotify commented Feb 26, 2024

Krishna2323 commented Feb 23, 2024 •

edited

Loading

Krishna2323 commented Feb 24, 2024 •

edited

Loading

Krishna2323 commented Feb 24, 2024 •

edited

Loading

s77rt commented Feb 25, 2024 •

edited

Loading

s77rt commented Feb 26, 2024 •

edited

Loading