-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CP Staging] Revert "Fix app returns to previous thread when scrubbing video in thread" #37161
[CP Staging] Revert "Fix app returns to previous thread when scrubbing video in thread" #37161
Conversation
@ Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
…llowups/app-returns-to-previous-thread-when-pressed-on-video [CP Staging] Revert "Fix app returns to previous thread when scrubbing video in thread" (cherry picked from commit 07681d4)
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Cherry-picked to staging by https://github.com/chiragsalian in version: 1.4.43-18 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
Tested on staging, going to check if off the checklist. |
🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.43-20 🚀
|
Straight revert of #37036, fixes bug where video player is not rendered when trying to post a video attachment (see example here)
Tests
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
![andriod native](https://github.com/Expensify/App/assets/91068263/1f0e7080-673a-426f-8743-e83af7cd25a6)Android: mWeb Chrome
![Screenshot 2024-02-22 at 17 30 13](https://github.com/Expensify/App/assets/91068263/3767a391-a4c5-4d7b-9a56-3794a09b9353)iOS: Native
![ios native](https://github.com/Expensify/App/assets/91068263/cb88fa28-0f72-43da-a64c-9cde1ccb9204)iOS: mWeb Safari
MacOS: Chrome / Safari
web_H.265.mp4
MacOS: Desktop
desktop_H.265.mp4