-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds haptic feedback on long press #37108
adds haptic feedback on long press #37108
Conversation
@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@ishpaul777 I see a lot of unrelated file changes. Can you please look into this? |
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.recording.Android.mp4Android: mWeb ChromeiOS: NativeRPReplay_Final1709563023.MP4iOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
@mountiny Can you please trigger a build for this? (Asking since this needs to be tested on native) |
Actually all are related changes, because in some places we use |
I'm specifically talking about iOS file changes like |
Oh sorry, thats from local build didn't notice while pushing changes will resolve these within half hour 🙃🙂 |
bd56f9f
to
ea79992
Compare
@allroundexperts Removed all unneccesary changes ) |
Asked for the build on Slack. |
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪 |
@allroundexperts Gentle bump 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
🚀 Deployed to staging by https://github.com/mountiny in version: 1.4.48-0 🚀
|
🚀 Deployed to production by https://github.com/roryabraham in version: 1.4.48-0 🚀
|
Details
This PR enables Haptic feedback for long press actions.
Fixed Issues
$ #35070
PROPOSAL: #35070 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
VIDEO-2024-02-23-03-19-41.mp4
Android: mWeb Chrome
N/A haptic feedback implementation is specific to native apps
iOS: Native
RPReplay_Final1708636910.MP4
iOS: mWeb Safari
N/A haptic feedback implementation is specific to native apps
MacOS: Chrome / Safari
N/A haptic feedback implementation is specific to native apps
MacOS: Desktop
N/A haptic feedback implementation is specific to native apps