Feature: Send image with text via composer #3708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jag96
suggested changes
Jun 22, 2021
| @@ -137,7 +137,7 @@ class AttachmentModal extends PureComponent { | |||
| success | |||
| style={[styles.buttonConfirm]} | |||
| textStyles={[styles.buttonConfirmText]} | |||
| text={this.props.translate('common.upload')} | |||
| text={this.props.translate('common.send')} | |||
There was a problem hiding this comment.
Can you remove the old upload const value if it is unused now?
| @@ -49,6 +49,7 @@ export default { | |||
| invite: 'Invite', | |||
| iAcceptThe: 'I accept the ', | |||
| passwordCannotBeBlank: 'Password cannot be blank', | |||
| send: 'Send', | |||
There was a problem hiding this comment.
Can you also make sure these updates are included in the es.js file? You can just google translate to Spanish for now
|
@Jag96 Updated. |
|
Ready for review |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
This was referenced Jun 25, 2021
|
🚀 Deployed to staging in version: 1.0.73-4🚀
|
|
🚀 Deployed to production in version: 1.0.74-0🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Fixed Issues
Fixes #2258
Tests | QA Steps
Tested On
Screenshots
Web
image-text-w.mp4
Mobile Web
image-text-m.mp4
Desktop
image-text-d.mp4
iOS
image-text-i.mp4
Android
image-text-a.mp4