Create the RequestCallPage #3697

jasperhuangg · 2021-06-21T02:32:55Z

Details

This PR creates the RequestCallPage and sets it up with react-navigation so that it can be accessed via navigating to <baseURL>/request-call. It also modifies the onPress handler for the call button in the Concierge DM to pull up the RequestCallPage.

Fixed Issues

Fixes https://github.com/Expensify/Expensify/issues/167901
Fixes https://github.com/Expensify/Expensify/issues/167902

Tests

Navigate to <baseURL>/request-call. Verify that the placeholder component displays.
Navigate to your chat with Concierge. Click on the call button. Verify that the placeholder component displays.
Set a display name and a secondary login in the settings. Verify that the form inputs are pre-filled correctly when you navigate to the request call page.
Submit the form on the request call page with an empty first/last name. Verify a growl error appears.
Submit the form on the request call page with an invalid phone number. Verify a growl error appears.
Submit the form on the request call page with valid inputs. Verify a success growl appears. Then verify an Expensiworks/InboxCallUser job is queued up in Bedrock.

QA Steps

Navigate to <baseURL>/request-call. Verify that the placeholder component displays.
Navigate to your chat with Concierge. Click on the call button. Verify that the placeholder component displays.
Set a display name and a secondary login in the settings. Verify that the form inputs are pre-filled correctly when you navigate to the request call page.
Submit the form on the request call page with an empty first/last name. Verify a growl error appears.
Submit the form on the request call page with an invalid phone number. Verify a growl error appears.
Submit the form on the request call page with valid inputs. Verify a success growl appears. Then verify an Expensiworks/InboxCallUser job is queued up in BJM.

Tested On

Screenshots

iOS

ios.mp4

Web

web.mp4

Desktop

desktop.mp4

…/Expensify.cash into jasper-requestCallPageNavSetup

…port data that didn't exist

jasperhuangg · 2021-06-23T01:20:06Z

@Dal-Papa Just took this off hold, so we should be good for a review. Thanks!!

src/components/FullNameInputRow.js

src/pages/RequestCallPage.js

Dal-Papa · 2021-06-23T09:16:05Z

src/pages/RequestCallPage.js

+    ...withLocalizePropTypes,
+
+    /** The personal details of the person who is logged in */
+    myPersonalDetails: PropTypes.shape({


Not sure if that's relevant but maybe checkout @Jag96's code for displaying phone numbers if that's the primary displayName of the user :
#3728

Dal-Papa · 2021-06-23T09:18:38Z

src/pages/RequestCallPage.js

+     */
+    getPhoneNumber(loginList) {
+        const secondaryLogin = _.find(loginList, login => Str.isSMSLogin(login.partnerUserID));
+        return secondaryLogin ? Str.removeSMSDomain(secondaryLogin.partnerUserID) : null;


Maybe something to consolidate with Joe's code ?

@Dal-Papa Joe's code assumes that the user is an SMS user, so it isn't entirely possible to reuse what he has. He assumes that the user's phone number is located somewhere in their personalDetails object, which isn't always the case for this particular page.

Dal-Papa

Looks good. Re-arranging your screencasts just to label them and then merging.

jasperhuangg · 2021-06-23T10:20:08Z

Thanks!! I figured they were already labeled in the title, but probably a good idea.

OSBotify · 2021-06-23T12:03:14Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2021-06-25T18:47:32Z

🚀 Deployed to staging in version: 1.0.73-4🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

marcaaron

Seems like there are some issues and this is breaking things for me on main

repro:

Go to /settings
Tap "Profile"
💥

marcaaron · 2021-06-25T20:22:50Z

src/components/FullNameInputRow.js

+import styles from '../styles/styles';
+import Text from './Text';
+import themeColors from '../styles/themes/default';
+import withLocalize, {withLocalizePropTypes} from './withLocalize';


If you use JSX then React must be included

marcaaron · 2021-06-25T20:23:45Z

src/pages/RequestCallPage.js

@@ -0,0 +1,171 @@
+import {Component} from 'react';


React must be included

Hey @marcaaron, sorry for the late reply! I noticed that this was broken and pushed a fix. It seems like it was broken when I merged a remote and local version of my branch.

marcaaron · 2021-06-25T20:31:46Z

Sorry was on an older branch actually seems like maybe it was fixed.

OSBotify · 2021-06-25T21:00:38Z

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

OSBotify · 2021-06-29T18:58:38Z

🚀 Deployed to production in version: 1.0.74-0🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

jasperhuangg added 2 commits June 21, 2021 10:23

setup for navigation

36fcc06

Navigate to the request call page from the Concierge DM

5dddf4e

jasperhuangg self-assigned this Jun 21, 2021

jasperhuangg added 8 commits June 21, 2021 10:38

Fix syntax, style

0099005

whitespace

dc5487d

fix import

95e29ab

Merge main

6658651

Fix merge conflict

47e5009

Fix merge conflict

842fe58

Get nav working

c86a520

Merge branch 'jasper-requestCallLocalization' of github.com:Expensify…

e0ddd97

…/Expensify.cash into jasper-requestCallPageNavSetup

jasperhuangg changed the title ~~Create and set up the RequestCallPage with react-navigation~~ Create the RequestCallPage Jun 22, 2021

jasperhuangg added 7 commits June 22, 2021 17:44

Add NameEntryInputRow component

3c14352

rename component + setup required fields

ab198b7

Handle errors thrown by the API

e25abcc

Fix case where reports weren't loaded and we were trying to access re…

595d09e

…port data that didn't exist

style

7992059

Add availability text

8e4cff8

remove whitespace

96e7f26

jasperhuangg changed the title ~~Create the RequestCallPage~~ [HOLD Expensify.cash #3696] Create the RequestCallPage Jun 22, 2021

fix color of call button for Concierge chats

fb5c2c3

jasperhuangg marked this pull request as ready for review June 22, 2021 12:36

jasperhuangg requested a review from a team as a code owner June 22, 2021 12:36

MelvinBot requested review from Dal-Papa and removed request for a team June 22, 2021 12:36

jasperhuangg changed the title ~~[HOLD Expensify.cash #3696] Create the RequestCallPage~~ Create the RequestCallPage Jun 23, 2021

Merge branch 'main' into jasper-requestCallPageNavSetup

aa9b5df

Dal-Papa reviewed Jun 23, 2021

View reviewed changes

cleanup imports and propTypes + fix merge conflict

9ceb2d4

jasperhuangg requested a review from Dal-Papa June 23, 2021 09:37

Dal-Papa approved these changes Jun 23, 2021

View reviewed changes

Dal-Papa merged commit f7dde80 into main Jun 23, 2021

Dal-Papa deleted the jasper-requestCallPageNavSetup branch June 23, 2021 12:02

This was referenced Jun 25, 2021

Deploy Checklist: Expensify.cash 2021-06-15 #3593

Closed

Deploy Checklist: Expensify.cash 2021-06-25 #3759

Closed

marcaaron added the DeployBlockerCash This issue or pull request should block deployment label Jun 25, 2021

marcaaron reviewed Jun 25, 2021

View reviewed changes

marcaaron removed the DeployBlockerCash This issue or pull request should block deployment label Jun 25, 2021

github-actions bot added the Engineering label Jun 25, 2021

github-actions bot added the Hourly KSv2 label Jun 25, 2021

jasperhuangg removed the Hourly KSv2 label Jun 28, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create the RequestCallPage #3697

Create the RequestCallPage #3697

jasperhuangg commented Jun 21, 2021 •

edited

Loading

jasperhuangg commented Jun 23, 2021

Dal-Papa Jun 23, 2021

Dal-Papa Jun 23, 2021

jasperhuangg Jun 23, 2021 •

edited

Loading

Dal-Papa left a comment

jasperhuangg commented Jun 23, 2021

OSBotify commented Jun 23, 2021

OSBotify commented Jun 25, 2021

marcaaron left a comment

marcaaron Jun 25, 2021

marcaaron Jun 25, 2021

jasperhuangg Jun 28, 2021

marcaaron commented Jun 25, 2021

OSBotify commented Jun 25, 2021

OSBotify commented Jun 29, 2021

Create the RequestCallPage #3697

Create the RequestCallPage #3697

Conversation

jasperhuangg commented Jun 21, 2021 • edited Loading

Details

Fixed Issues

Tests

QA Steps

Tested On

Screenshots

iOS

Web

Desktop

jasperhuangg commented Jun 23, 2021

Dal-Papa Jun 23, 2021

Choose a reason for hiding this comment

Dal-Papa Jun 23, 2021

Choose a reason for hiding this comment

jasperhuangg Jun 23, 2021 • edited Loading

Choose a reason for hiding this comment

Dal-Papa left a comment

Choose a reason for hiding this comment

jasperhuangg commented Jun 23, 2021

OSBotify commented Jun 23, 2021

OSBotify commented Jun 25, 2021

marcaaron left a comment

Choose a reason for hiding this comment

marcaaron Jun 25, 2021

Choose a reason for hiding this comment

marcaaron Jun 25, 2021

Choose a reason for hiding this comment

jasperhuangg Jun 28, 2021

Choose a reason for hiding this comment

marcaaron commented Jun 25, 2021

OSBotify commented Jun 25, 2021

OSBotify commented Jun 29, 2021

jasperhuangg commented Jun 21, 2021 •

edited

Loading

jasperhuangg Jun 23, 2021 •

edited

Loading